You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix: give two methods the organizationId their routes need - #434
Stacked on #422 so its changelog entry cannot conflict with the 1.74 chain. Merges as 1.74.13.
Before merging, retarget the base to main. Base branches are not auto-deleted in this repo, so GitHub will not retarget for you. Merge only after #422 is on main, with a merge commit; do not squash, rebase or click Update branch.
Why
The Dependabot Refit 16 upgrades (#432, #433) fail to build with two RF015 errors from Refit 16's new analyzer. They are real bugs, not a Refit regression: both routes contain {organizationId} and no parameter fills it, so Refit throws before sending on every call, with Refit 15 too.
string organizationId (positional callers unaffected; serial: named callers must rename)
No code in the repo calls either method.
Evidence
New Meraki.Api.Test.Client.UnmatchedRouteParameterTests builds the Refit client with MerakiClient's settings over a recording handler (same pattern as #428's test). Before the fix the camera test failed with:
System.ArgumentException : URL /organizations/{organizationId}/camera/customAnalytics/artifacts has parameter {organizationId}, but no method parameter matches
After: both pass. I also trialled each Dependabot bump locally on top of this branch (not committed):
Comment @dependabot rebase on #432 and #433 and they should go green. Note each bumps Refit plus one companion, leaving the other at 15.2.0. Merging one will make Dependabot rebase the other, and after both all three are on 16.3.0.
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
UpdateOrganizationApplianceVpnSiteToSiteIpsecPeersSlasAsync had no
organization parameter, and CreateOrganizationCameraCustomAnalyticsArtifactAsync
named it "serial". Both routes contain {organizationId}, so Refit threw
ArgumentException before sending and neither method could ever succeed.
Refit 16's RF015 analyzer rejects both declarations, which is what broke the
Dependabot Refit 16 upgrades.
UnmatchedRouteParameterTests builds the Refit client over a recording
handler and checks each request path; the camera test reproduced the
ArgumentException before the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Dependabot Refit 16 upgrades (#432, #433) fail to build with two
RF015errors from Refit 16's new analyzer. They are real bugs, not a Refit regression: both routes contain{organizationId}and no parameter fills it, so Refit throws before sending on every call, with Refit 15 too.IOrganizationsVpnSiteToSiteIpsec.UpdateOrganizationApplianceVpnSiteToSiteIpsecPeersSlasAsyncstring organizationIdfirst, likeGetOrganizationApplianceVpnSiteToSiteIpsecPeersSlasAsyncICameraCustomAnalyticsArtifacts.CreateOrganizationCameraCustomAnalyticsArtifactAsyncstring serialstring organizationId(positional callers unaffected;serial:named callers must rename)No code in the repo calls either method.
Evidence
New
Meraki.Api.Test.Client.UnmatchedRouteParameterTestsbuilds the Refit client withMerakiClient's settings over a recording handler (same pattern as #428's test). Before the fix the camera test failed with:After: both pass. I also trialled each Dependabot bump locally on top of this branch (not committed):
After this merges
Comment
@dependabot rebaseon #432 and #433 and they should go green. Note each bumps Refit plus one companion, leaving the other at 15.2.0. Merging one will make Dependabot rebase the other, and after both all three are on 16.3.0.