Repository navigation
Add root Meraki.Cli.slnx so CI build and CodeQL succeed - #3
Merged
Merged
Conversation
…d find the project The only project lives in content/ (the dotnet new template source), so `dotnet restore` at the repo root failed with MSB1003. Add a root solution referencing content/Meraki.Cli.csproj. Building it under the root Directory.Build.props (TreatWarningsAsErrors + GenerateDocumentationFile) exposed three missing XML doc warnings in the template source; document them. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI
buildfails at Restore withMSB1003: Specify a project or solution file, and CodeQL autobuild fails likewise: the repo root has no solution/project. The only project iscontent/Meraki.Cli.csproj(thedotnet newtemplate source).Change
Meraki.Cli.slnx(solution items folder +content/Meraki.Cli.csproj), matching peer repos.content/Application.csandcontent/Program.cs; the rootDirectory.Build.props(TreatWarningsAsErrors + GenerateDocumentationFile) now applies to the template and made them CS1573/CS1591 errors.Verified locally
dotnet restoreanddotnet build -c Release --no-restorefrom the root succeed, 0 warnings, 0 errors. No test projects exist.Note (not changed here)
dotnet packis a silent no-op: the Worker SDK project is not packable andMeraki.Cli.nuspeclists no files, so no template .nupkg is produced and the publish job would have nothing to push. Needs a separate fix.🤖 Generated with Claude Code