Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 66 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,71 @@ jobs:
name: packages
path: ./artifacts/*.nupkg

# Collects line coverage and publishes it to Codacy. Runs on the self-hosted
# pdl-public scale set rather than a GitHub-hosted runner.
# pdl-public is the hardened scale set that may serve a public repository: a
# fork pull request is untrusted code, so it has no dind, no privileged
# container, no hostPath and nothing shared between jobs.
coverage:
runs-on: [pdl-public]

env:
DOTNET_NOLOGO: 1
DOTNET_CLI_TELEMETRY_OPTOUT: 1
# The actions-runner image does not offer the Node version several of these
# actions request by default; without this they fail before their first step.
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true

steps:
- name: Checkout
uses: actions/checkout@v7
with:
fetch-depth: 0 # Nerdbank.GitVersioning needs the full history.

- name: Setup .NET
uses: actions/setup-dotnet@v6
env:
# The runner user cannot write /usr/share/dotnet, the default install location.
DOTNET_INSTALL_DIR: ${{ runner.temp }}/dotnet
with:
dotnet-version: 10.0.x

- name: Build tests
run: dotnet build PanoramicData.OData.Client.Test/PanoramicData.OData.Client.Test.csproj --configuration Debug

# The test project is a Microsoft.Testing.Platform application
# (UseMicrosoftTestingPlatformRunner), so coverage is collected by running the
# test executable directly with Microsoft.Testing.Extensions.CodeCoverage rather
# than through `dotnet test`. On Linux the executable has no .exe extension.
# coverage.config ports coverlet's generated-code exclusions so figures stay
# comparable across the estate.
- name: Run tests with coverage
run: >-
./PanoramicData.OData.Client.Test/bin/Debug/net10.0/PanoramicData.OData.Client.Test
--coverage
--coverage-settings PanoramicData.OData.Client.Test/coverage.config

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃敶 HIGH RISK

The file 'PanoramicData.OData.Client.Test/coverage.config' is missing from the PR. Please include this file to ensure the coverage run can complete successfully with the intended exclusions.

--coverage-output-format cobertura
--coverage-output coverage.cobertura.xml

# continue-on-error: a Codacy outage must not turn a passing test run red. The
# trade-off is that an expired or missing project token fails silently, so
# check the step log for "Coverage received successfully".
- name: Upload coverage to Codacy
continue-on-error: true
uses: codacy/codacy-coverage-reporter-action@v1
with:
project-token: ${{ secrets.CODACY_PROJECT_TOKEN }}
coverage-reports: PanoramicData.OData.Client.Test/bin/Debug/net10.0/TestResults/coverage.cobertura.xml

- name: Upload coverage artifact
if: always()
continue-on-error: true
uses: actions/upload-artifact@v7
with:
name: coverage
path: PanoramicData.OData.Client.Test/bin/Debug/net10.0/TestResults/coverage.cobertura.xml
Comment on lines +81 to +104

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃敶 HIGH RISK

The coverage report path in the upload steps is incorrect. The test runner generates the report based on the working directory (root) or the --coverage-output flag (line 86), but the upload steps (lines 96, 104) look in the project's 'bin/Debug' folder. To fix this, explicitly set the results directory and use a consistent path:

  1. Add --results-directory TestResults to the test command.
  2. Update the upload steps to use 'TestResults/coverage.cobertura.xml'.

retention-days: 7

publish:
needs: build
runs-on: ubuntu-latest
Expand All @@ -64,4 +129,4 @@ jobs:
user: david_n_m_bond

- name: Push to NuGet
run: dotnet nuget push ./artifacts/*.nupkg --api-key ${{ steps.login.outputs.NUGET_API_KEY }} --source https://api.nuget.org/v3/index.json --skip-duplicate
run: dotnet nuget push ./artifacts/*.nupkg --api-key ${{ steps.login.outputs.NUGET_API_KEY }} --source https://api.nuget.org/v3/index.json --skip-duplicate
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

<PropertyGroup>
<TargetFramework>net10.0</TargetFramework>
<UseMicrosoftTestingPlatformRunner>true</UseMicrosoftTestingPlatformRunner>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<IsPackable>false</IsPackable>
Expand Down
Loading