Skip to content

Make the coverage.config obj exclusion match on Linux #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidnmbond merged 2 commits into from
Oct 3, 2026
Merged

Make the coverage.config obj exclusion match on Linux #55

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41e6ffa
OPS-157454: Make the coverage.config obj exclusion match on Linux
davidnmbond Oct 3, 2026
44e969f
OPS-157454: Make the coverage.config obj exclusion match on Linux and…
davidnmbond Oct 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion PanoramicData.OData.Client.Test/coverage.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
</Attributes>
<Sources>
<Exclude>
<Source>.*\obj\.*</Source>
<Source>.*[\\/]obj[\\/].*</Source>

@codacy-production codacy-production Bot Oct 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 MEDIUM RISK

This pattern requires a preceding separator, meaning it will not match relative paths starting with obj/. To support both absolute and relative paths, allow the start of the string as an alternative to the separator.

Suggested change
<Source>.*[\\/]obj[\\/].*</Source>
<Source>.*([\\/]|^)obj[\\/].*</Source>

<Source>.*\Benchmarks\.*</Source>

@codacy-production codacy-production Bot Oct 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ LOW RISK

Suggestion: The Benchmarks exclusion should be updated to use the same cross-platform path separator pattern as the obj directory to ensure consistency and correct behavior on Linux. Additionally, \B is likely being interpreted as a regex anchor rather than a path component.

Suggested change
<Source>.*\Benchmarks\.*</Source>
<Source>.*[\\/]Benchmarks[\\/].*</Source>

</Exclude>
</Sources>
Expand Down
Loading