-
Notifications
You must be signed in to change notification settings - Fork 5
OPS-157454: Group live OData tests as integration and exclude them from CI #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -27,8 +27,9 @@ jobs: | |||||
| - name: Build | ||||||
| run: dotnet build --configuration Release --no-restore | ||||||
|
|
||||||
| # Integration tests call the public services.odata.org sample services and are run locally, never in CI. | ||||||
| - name: Test | ||||||
| run: dotnet test --configuration Release --no-build --verbosity normal | ||||||
| run: dotnet test --configuration Release --no-build --verbosity normal --filter-not-trait "Category=Integration" | ||||||
|
|
||||||
| - name: Pack | ||||||
| run: dotnet pack --configuration Release --no-build --output ./artifacts | ||||||
|
|
@@ -84,6 +85,7 @@ jobs: | |||||
| --coverage-settings PanoramicData.OData.Client.Test/coverage.config | ||||||
| --coverage-output-format cobertura | ||||||
| --coverage-output coverage.cobertura.xml | ||||||
| --filter-not-trait "Category=Integration" | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔴 HIGH RISK The '--filter-not-trait' flag is not supported by the testing platform. Use the '--filter' option with a conditional expression to exclude the integration category.
Suggested change
|
||||||
|
|
||||||
| # continue-on-error: a Codacy outage must not turn a passing test run red. The | ||||||
| # trade-off is that an expired or missing project token fails silently, so | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 HIGH RISK
The '--filter-not-trait' argument is invalid and will cause the filter to be ignored or the command to fail. Use the standard '--filter' option instead:
Additionally, excluding these tests has dropped the coverage of 'ODataClient.ServiceDocument.cs' from 87.5% to 0%. Consider implementing unit tests using a mocked HttpClient or HttpMessageHandler to test ServiceDocument parsing with static XML payloads, ensuring this logic is validated in CI without requiring live OData services.
See Coverage in Codacy