Skip to content

Hash rule is not what it tells you it is #193

Description

@RobQuistNL

What

The hash rule actually validates against a hexidecimal string representation of a hash. You might want to add that in the name, because in essence the hashes named are just a bunch of bits / bytes. The fact that PHP represents most in hex doesn't mean that something is a valid / invalid hash.

What is expected

Rename it to HashRepresentation($hash_algo, Hash::HEXIDECIMAL_INSENSITIVE) or something, indicating that you're validating a hexidecimal representation of a hash.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions