Repository navigation
Add metadataKeyFingerprint and trustNewMetadataKey - #141
Open
juanjorosendo wants to merge 1 commit into
Open
juanjorosendo wants to merge 1 commit into
juanjorosendo wants to merge 1 commit into
Conversation
The SDK only trusts a Shared Metadata Key whose private key copy is signed by the user's own key. A copy shared by an administrator is signed by theirs, so those users cannot write v5 metadata and every share fails with "metadata Key has changed, The Callback is nil, There is a Key Pinned but the new one is not trusted", with no key pinned. The CLI set neither a fingerprint nor MetadataKeyUpdatedCallback, so there was no way past it. metadataKeyFingerprint pins the expected key, and trustNewMetadataKey accepts the one the server offers when the fingerprint is unknown. Both default to off. Tested against Passbolt 5.16.0 CE with a regular and an administrator account: share fails without either and succeeds with each. 28_resource_share_locked.txtar keeps its negative assertion. Its environment produces the other state it describes, where the user has no private key copy at all, and neither flag applies there.
|
|
Contributor
|
Hi @juanjorosendo, Thank you for reporting this issue. |
Contributor
|
Ticket associated: PB-55536 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDK only trusts a Shared Metadata Key whose private key copy is signed by the user's own key. A copy shared by an administrator is signed by theirs, so those users cannot write v5 metadata and every share fails with "metadata Key has changed, The Callback is nil, There is a Key Pinned but the new one is not trusted", with no key pinned.
The CLI set neither a fingerprint nor MetadataKeyUpdatedCallback, so there was no way past it. metadataKeyFingerprint pins the expected key, and trustNewMetadataKey accepts the one the server offers when the fingerprint is unknown. Both default to off.
Tested against Passbolt 5.16.0 CE with a regular and an administrator account: share fails without either and succeeds with each.
28_resource_share_locked.txtar keeps its negative assertion. Its environment produces the other state it describes, where the user has no private key copy at all, and neither flag applies there.