Repository navigation
Conversation
TarasKosh
marked this pull request as ready for review
November 18, 2026 01:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After access expiry, concurrent MCP requests can refresh the same rotating OAuth token. One renewal succeeds while another receives
invalid_grant; the SDK can then clear the newly saved credentials and require another login.This change coordinates SDK renewal per credential provider, reuses the saved winner for late 401 responses, and preserves parallel authenticated reads. Rejected renewal reports
needs-authand stops automatic replay. Previously challenged scopes remain available to the SDK's later scope step-up without changing authorization-server-issued token scopes. The official SDK OAuth flow, secure secret backend, resource binding and per-server identity remain in place.Validation:
a156e6878676065725edd12b23917c49131042f3, with 20 targeted checks. The earlier review of594a54dfound the scope regression; that finding is retained and closed by the follow-up. The review report was supplied privately and has not been published as a GitHub review.No installed/live OAuth validation has been performed. Remote MCP server persistence across restarts is a separate follow-up. The reproduced client defect does not establish the exact cause of a historical live incident.
Delivery: the affected installation tracks
agent-plugins/^0.3.0; this main-based candidate has package version 0.4.0. A compatible backport/release is needed for an update within that channel. A full 0.4.0 update also includes upstream attention UI and pasted-callback changes since 0.3.1.Runtime behavior changed: yes
Living contract changed: no