Repository navigation
chore: drop runtime migrations that all live chains have applied - #396
Merged
sfffaaa merged 1 commit intoSep 7, 2026
Merged
Conversation
Session/Contracts/XcmpQueue/AuraExt each carry a VersionedMigration that guards on the pallet's storage version, so once a chain is past it the entry only costs weight and PoV on every later upgrade, and its pre_upgrade check can fail loudly on already-migrated state. All of them are past on every chain that still exists, read from the live chains rather than inferred: peaq mainnet (spec 113) Session=1 Contracts=16 XcmpQueue=5 AuraExt=1 agung (spec 108) Session=1 Contracts=16 XcmpQueue=5 AuraExt=1 krest is included because the chain is decommissioned, so it has no upgrade path left to protect. pallet_xcm::migration::MigrateToLatestXcmVersion stays. It is not a one-shot: it has no storage-version guard and re-arms the lazy XCM version migration whenever CurrentXcmVersion changes, which upstream documents as "can be permanently added to the runtime migrations". Every one of the eleven runtimes shipped in polkadot-sdk keeps it, and the // permanent comment above it records the same intent. The block-reward v3 migration is untouched. It lives in the pallet's own on_runtime_upgrade hook rather than in this tuple, and agung is still on BlockReward storage version 4, so it has yet to run there. cargo check -p peaq-runtime -p peaq-dev-runtime -p peaq-krest-runtime: exit 0, no warnings. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FQvgVJ4Vh2n5HitQQQwwGP
sfffaaa
deleted the
feature/blk-1011-release-token-economy-20-merge-to-dev
branch
September 7, 2026 11:13
sfffaaa
pushed a commit
that referenced
this pull request
Sep 7, 2026
Conflict was runtime/krest/src/lib.rs: dev trimmed its Migrations tuple in 6b15332 (merged as #396) while this branch deletes the file outright. Kept the deletion — the krest network is decommissioned, so the runtime goes away entirely and the tuple edit is moot. Nothing else conflicted; dev's remaining changes to runtime/peaq and runtime/peaq-dev merge cleanly. `grep -ril krest` over the merged tree (excluding target/, .git/, Cargo.lock) reports no matches. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FQvgVJ4Vh2n5HitQQQwwGP
sfffaaa
pushed a commit
that referenced
this pull request
Sep 7, 2026
Conflict was runtime/krest/src/lib.rs: dev trimmed its Migrations tuple in 6b15332 (merged as #396) while this branch deletes the file outright. Kept the deletion — the krest network is decommissioned, so the runtime goes away entirely and the tuple edit is moot. Nothing else conflicted; dev's remaining changes to runtime/peaq and runtime/peaq-dev merge cleanly. `grep -ril krest` over the merged tree (excluding target/, .git/, Cargo.lock) reports no matches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.