Repository navigation
chore: remove the krest runtime and node wiring - #397
Merged
Merged
Conversation
The krest network is decommissioned, so the runtime, its chain specs and the
node code that could select them no longer have a chain to serve. Keeping
them means every workspace build still compiles a runtime nobody can run, and
`--chain krest` remains reachable on the CLI.
Removed outright:
runtime/krest/
node/src/parachain/krest_chain_spec.rs
node/src/chain-specs/krest-raw.json
Unwired from the node: the `is_krest` predicates, the `with_runtime_or_err!`
arm, the "krest"/"krest-local" load_spec entries, the ChainSpec::from_json_file
branch, `runtime_version`, `declare_executor!`, the module declaration, and the
peaq-krest-runtime dependency together with its aura, runtime-benchmarks and
try-runtime feature entries. The krest-v* tag trigger is dropped from the
Docker Hub workflow, and the README and benchmark script lose their krest
sections. The workspace manifest needs no change because members globs
runtime/*.
pallet-inflation-manager's migrate_to_v1 goes too. It was documented as
krest-only ("This migration will trigger for krest runtime, but not peaq
runtime") and guards on `on_chain_storage_version < 1`, which no surviving
chain can satisfy:
peaq mainnet (spec 113) InflationManager StorageVersion = 2
agung (spec 108) InflationManager StorageVersion = 2
migrate_to_v2 is untouched; it is not krest-specific.
cargo check --workspace: exit 0. The two dead-field warnings it reports are
in node/src/rpc.rs, which this change does not touch.
sfffaaa
force-pushed
the
feature/blk-1010-remove-krest-runtime
branch
from
September 7, 2026 08:21
83e6ed5 to
57708fa
Compare
Conflict was runtime/krest/src/lib.rs: dev trimmed its Migrations tuple in 6b15332 (merged as #396) while this branch deletes the file outright. Kept the deletion — the krest network is decommissioned, so the runtime goes away entirely and the tuple edit is moot. Nothing else conflicted; dev's remaining changes to runtime/peaq and runtime/peaq-dev merge cleanly. `grep -ril krest` over the merged tree (excluding target/, .git/, Cargo.lock) reports no matches.
sfffaaa
force-pushed
the
feature/blk-1010-remove-krest-runtime
branch
from
September 7, 2026 12:24
1d159ef to
42cd743
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The krest network is decommissioned, so its runtime, chain specs and the node code that can select them no longer have a chain to serve. Until now every workspace build still compiled a runtime nobody can run, and
--chain kreststayed reachable on the CLI.Removed outright
runtime/krest/node/src/parachain/krest_chain_spec.rsnode/src/chain-specs/krest-raw.jsonUnwired from the node
is_krest(both impls), thewith_runtime_or_err!arm, the"krest"/"krest-local"load_specentries, theChainSpec::from_json_filebranch,runtime_version,declare_executor!, the module declaration, and thepeaq-krest-runtimedependency with itsaura/runtime-benchmarks/try-runtimefeature entries.Also: the
krest-v*tag trigger in the Docker Hub workflow, and the krest sections of the README and the benchmark script. The workspace manifest needs no change —membersglobsruntime/*.pallet-inflation-manager
migrate_to_v1is removed as well. It was documented as krest-only ("This migration will trigger for krest runtime, but not peaq runtime") and guards onon_chain_storage_version < 1, which no surviving chain can satisfy — read from the live chains:InflationManagerStorageVersionmigrate_to_v2is untouched; it is not krest-specific.Verification
cargo check --workspace→ exit 0node/src/rpc.rs, which this change does not touchgrep -ril krestover the tree (excludingtarget/,.git/) → no matches20 files changed, 5 insertions(+), 4381 deletions(-)