[BREAKINGCHANGE] Upgrade to Node 24 (LTS) and remove CommonJS - #779
Conversation
065fd5b to
d463747
Compare
Gladorme
changed the title
970c818 to
6c6223a
Compare
There was a problem hiding this comment.
I can't remove it without having an issue with mdi-material-ui icons deep imports (from shared) :[
There was a problem hiding this comment.
Looking for a solution, I see Rspack is providing lazy barrel imports and could make use remove the rule about not importing from main barrel (https://rspack.rs/guide/optimization/lazy-barrel), as md-matrerial-ui looks to be built with sideEffect: false. And I guess we should do it also for Perses components. It can reduce bundle size for embedded usage
There was a problem hiding this comment.
I don't get all, but two questions
- Is it blocking this PR, or working but not elegant
- Can you create an issue if something needs to be changed after the PR
There was a problem hiding this comment.
Working but not elegant
| @@ -38,6 +38,11 @@ const sharedConfig = defineConfig({ | |||
| environment: 'jsdom', | |||
| globals: true, | |||
| include: ['src/**/*.test.{ts,tsx,js,jsx}', 'src/**/*.spec.{ts,tsx,js,jsx}'], | |||
| server: { | |||
There was a problem hiding this comment.
Related to previous comment :[
There was a problem hiding this comment.
I don't get all, but two questions
- Is it blocking this PR, or working but not elegant
- Can you create an issue if something needs to be changed after the PR
- Update build tooling and package metadata for ESM output - Enforce type-only imports across plugins Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
6c6223a to
93e8629
Compare
2 participants
Description
Related PR:
Screenshots
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes