Parallel runs on Windows PowerShell 5.1, and what throttle 1 does - #449
Open
nohwnd wants to merge 1 commit into
Open
Parallel runs on Windows PowerShell 5.1, and what throttle 1 does#449nohwnd wants to merge 1 commit into
nohwnd wants to merge 1 commit into
Conversation
Parallel no longer needs PowerShell 7, so drop the ForEach-Object -Parallel engine from the description and the 5.1 entry from the fallback list. Needs pester/Pester#2987. ParallelThrottleLimit reads like a way to turn parallel off when you set it to 1, and it is not. The files still go through the parallel machinery, one at a time in their own runspace, so debugging still does not work, breakpoints are per runspace. Say that, and say the throttle does nothing at all unless Run.Parallel is on. 🤖
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run.Parallelno longer needs PowerShell 7 (pester/Pester#2987, merged), so this drops theForEach-Object -Parallelengine from the description and the 5.1 entry from the fallback list.Run.ParallelThrottleLimit = 1reads like a way to turn parallel off, and it is not. The files still go through the parallel machinery, one at a time in their own runspace, so you keep the isolation and you keep what comes with it: a breakpoint set in the calling session does not hit inside a worker, breakpoints are per runspace. To step through, setRun.Parallelto$false. Came up in pester/Pester#2971 and pester/Pester#2973.Also says the throttle does nothing on its own, a run that is not parallel has nothing to throttle.
🤖