Use the term "soft assertions" on the v5 Should page - #450
Open
nohwnd wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The word "soft assertion" did not appear anywhere in the v5 docs, so searching pester.dev for it missed the page that actually describes the behavior. Renames the heading to "Collect all Should failures (soft assertions)", uses the term in the text, and mentions
-ErrorAction Stopfor guarding a precondition.The v6 side of #385 is already done:
assertions/soft-assertionslanded in #397, it is in the sidebar, and all 41 generatedShould-*pages carry the-ErrorActionexplanation. So this is the last piece and #385 can close once it merges.🤖