Repository navigation
Conversation
Author
|
Hey @nunomaduro, please take a look when you have time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drift adds the
uses()call at the very top of the file, so a test that starts withdeclare(strict_types=1);stops parsing after conversion. It now goes after the declare statement.self::andstatic::calls survived the conversion too, and they fatal once the class wrapper is gone. They now become$this->calls, which also lets the existing assertion rules pick upself::assertTrue()and the like. Calls inside a nested or anonymous class are left untouched.Fixes pestphp/pest#1901