Repository navigation
fix: accept --no-results and the --do-not-* test run history options with --parallel - #1982
Open
adilKhan72 wants to merge 1 commit into
Open
adilKhan72 wants to merge 1 commit into
adilKhan72 wants to merge 1 commit into
Conversation
…ons with `--parallel`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Description:
pest --parallelfails with these PHPUnit options, whilepestwithout--parallelaccepts them:The parallel handler removes
--cache-resultand--record-test-run-historybefore it passes the arguments to ParaTest, but not their--do-not-*counterparts or--no-results, and ParaTest does not know these options. The workers do not need them: ParaTest always runs the workers with--do-not-record-test-run-historyand--no-output.This PR removes the three options in the parallel handler. The
--do-not-*options also stop the parent process from writing the merged test run history, so a parallel run gives the same result as a run without--parallel(before, it always wrote the history).Tests were added to
tests/Visual/Parallel.phpfor the three options and for the history file, with and without--do-not-*.Related:
Found while looking into #1946.