Repository navigation
Keep blogrolls on password-protected pages private - #49
Merged
Merged
Conversation
pfefferle
force-pushed
the
fix/password-protected-blogrolls
branch
from
October 15, 2026 11:24
165fb0f to
8f427e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A blogroll on a page behind a password was not private:
?opmlon that page served every link, and the page was listed inrecommendations.opml,following.opmland the feed. With the CORS change in #48 any other site could read that too.Password-protected pages are now left out of all site-wide lists (
has_password => false), and?opmlon such a page loads the page with its password form, until the visitor entered the password. The page also prints norel="blogroll"links then.Found by a code review of #48.