fix cross-shard ORDER BY on non-projected columns - #1517
Open
murex971 wants to merge 6 commits into
Open
Conversation
murex971
commented
Sep 10, 2026
Contributor
- Temporarily project missing ORDER BY columns during query rewriting.
- Use hidden columns for correct global cross-shard sorting.
- Remove hidden columns before sending rows and RowDescription to clients.
- Support direct-shard results.
- closes [Query Engine] ORDER BY on non-projected column can produce incorrect cross-shard ordering #1135
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
levkk
reviewed
Sep 10, 2026
| mut message: Message, | ||
| ) -> Result<(), Error> { | ||
| if !self.backend.is_multishard() { | ||
| drop_projected_columns( |
Collaborator
There was a problem hiding this comment.
Aren't we calling drop_columns twice now? Once in multi shard binding, and once here, so twice for multi-shard queries and once for direct-to-shard queries.
levkk
reviewed
Sep 10, 2026
| } | ||
| } | ||
|
|
||
| fn drop_projected_columns( |
Collaborator
There was a problem hiding this comment.
I would probably push this concern into the connection binding (e.g.. read method). The architecture is as such that piece of code handles the cross-shard/direct-to-shard message manipulation. The query engine doesn't actually know whether it's talking to one or more servers, so this leaks it here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.