Repository navigation
Conversation
semohr
force-pushed
the
defs_msgspec
branch
2 times, most recently
from
May 9, 2026 14:11
18ed73b to
e865197
Compare
Contributor
Author
|
@pgjones Just rebased this onto the current main. As an fyi, the relevant fix here is only 4 lines of code https://github.com/pgjones/quart-schema/pull/121/changes#diff-bb03e7c14618ef165764f689b7697aa220ebc69c70daa3bfbe35e7abc18e585cR211 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a followup to #120 I found that such
TypedDictswith generics do generate references in the json schema returned bymsgspecbut these are not used inquart-schema. These references are now returned correctly.Should fix #117