Skip to content

Replace insightsengineering with pharmaverse - #393

Merged
llrs-roche merged 11 commits into
mainfrom
392_pharmaverse
Oct 26, 2026
Merged

llrs-roche merged 11 commits into
mainfrom
392_pharmaverse

Conversation

@llrs-roche

Copy link
Copy Markdown
Member

Pull Request

Fixes #392

Note that when documenting to replace some content from the help page two sections unrelated were removed.

✖ In topic 'teal_data-class': @inherits failed to find topic teal.code::`qenv-class`.

I'm not sure what is wrong, I tried replacing it with teal.code::qenv-class but it didn't help. I think it is regression on roxygen2 version 8.1.0 as it worked for version 0.8.0. I had to reinstall it and work with it, but that might mean it will fail the roxygen2 check on the CI

@llrs-roche llrs-roche added the core label Sep 9, 2026
@github-actions

github-actions Bot commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

Unit Tests Summary

  1 files   15 suites   2s ⏱️
163 tests 163 ✅ 0 💤 0 ❌
218 runs  218 ✅ 0 💤 0 ❌

Results for commit e499610.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

badge

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  -------------------
R/cdisc_data.R                   1       0  100.00%
R/deprecated.R                  18       0  100.00%
R/dummy_function.R               2       2  0.00%    15-16
R/formatters_var_labels.R       61       0  100.00%
R/join_key.R                    38       0  100.00%
R/join_keys-c.R                 12       0  100.00%
R/join_keys-extract.R          128       0  100.00%
R/join_keys-names.R             15       0  100.00%
R/join_keys-parents.R           30       0  100.00%
R/join_keys-print.R             45       0  100.00%
R/join_keys-utils.R             73       3  95.89%   35-38
R/join_keys.R                   21       0  100.00%
R/teal_data-class.R             36       6  83.33%   57-59, 66, 111-112
R/teal_data-constructor.R       11       2  81.82%   48, 51
R/teal_data-extract.R            3       0  100.00%
R/teal_data-get_code.R          13       8  38.46%   114-120, 124
R/teal_data-names.R              8       1  87.50%   42
R/teal_data-show.R               5       5  0.00%    14-20
R/topological_sort.R            32       0  100.00%
R/verify.R                      42      11  73.81%   67, 97-101, 104-108
TOTAL                          594      38  93.60%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: e499610

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@averissimo averissimo self-assigned this Sep 14, 2026

@averissimo averissimo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 minor comment and an actual typo on the link

Comment thread R/join_keys-names.R
Comment thread vignettes/join-keys.Rmd Outdated
Co-authored-by: André Veríssimo <211358+averissimo@users.noreply.github.com>
Signed-off-by: Lluís Revilla <185338939+llrs-roche@users.noreply.github.com>
Comment thread man/teal_data-class.Rd

@averissimo averissimo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 awesome!

It has a pending removal, but we may mitigate this for now by adding the section manual. WDYT?

@llrs-roche
llrs-roche merged commit 6d89900 into main Oct 26, 2026
28 of 30 checks passed
@llrs-roche
llrs-roche deleted the 392_pharmaverse branch October 26, 2026 09:14
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move to Pharmaverse

2 participants