Repository navigation
fix(client): capture large transcripts and reclaim acknowledged snapshots - #111
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remote transcript capture currently shares its 16 MiB budget with pending uploads; a ~90 MiB active native transcript therefore cannot be captured, and acknowledged snapshots never release their storage. This blocks the planned local-to-Hetzner client cutover.
This change gives source snapshots a separate configurable 256 MiB budget while preserving the 16 MiB outbox bound. Native snapshots are released only after clean EOF for the exact snapshot and durable server acknowledgement of every staged window. Prefix hashes/cursors survive release; unknown legacy acknowledgements, incomplete tails, concurrent appends and Gemini adapter history remain retained. SQLite waits are bounded, and package generators plus
rag installgive capture hooks 30 seconds.Compatibility: version 0.6.35, additive local SQLite metadata, unchanged protocol 1 and PostgreSQL migrations 001–039. Covers existing spools, old-client append during rollback, credential partitions, populated-store upgrade and lost-ACK HTTP replay. Documented downgrade limits preserve pending input; server acceptance is distinct from applied extraction. Production clients and canonical data have not been switched.
Validation on final input bytes: 193 targeted tests passed, 1 skipped, 1 existing Starlette warning (64.50 s); a real 94 MiB concurrent-capture probe preserved both sources. Independent complete review plus correction review; all blocking findings resolved, including the mechanically corrected installer deadlines (red: 3 failed; green: 106 passed, 1 skipped). Wheel package and all 39 SQL files match the source. No full-suite rerun for this bounded correction.
Remaining operational Low findings (SQLite contention reporting, advisory-hook latency and safe Gemini/session-metadata retirement) are tracked in #75. Original host transcripts must remain available for raw provenance audits. No automatic data migration or activation occurs on install.
Closes #110. Related to #58.