libm: Import secondary math library implementation by ayoopierre · Pull Request #507 · phoenix-rtos/libphoenix

ayoopierre · 2026-07-21T09:58:27Z

Add secondary math libary implementation

Description

Import secondary math library implementation, with selection which version to build (external libmcs implementation/libphoenix implementation) and selection for usage of hw intrinsics for math operations.

Motivation and Context

Libmcs provides complete C99 math library implementation.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

Already covered by automatic testing.
New test added: (add PR link here).
Tested by hand on: (list targets here).

Checklist:

My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing linter checks and tests passed.
My changes generate no new compilation warnings for any of the targets.

Special treatment

This PR needs additional PRs to work (list the PRs, preferably in merge-order).
- libm: Add compatibility for new libm phoenix-rtos-ports#144
- libm: Add libm compatibility in build phoenix-rtos-build#291
I will merge this PR by myself when appropriate.

github-actions · 2026-07-21T09:58:43Z

+ *
+ * %LICENSE%
+ */
+


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

github-actions · 2026-07-21T09:58:54Z

+
+# Notes
+1. This is a temporary state, moving math library to be separate to libphoenix
+2. Some hardware instrinsics for math functions are still not implemented 


[codespell] _{reported by reviewdog 🐶}
instrinsics ==> intrinsics

github-actions · 2026-07-21T09:58:54Z

+		init->i.mantisa |= (0x1ull << 51);
+	}
+
+	/* Reciprocal sqare root iters (avoiding division): */


[codespell] _{reported by reviewdog 🐶}
sqare ==> square

gemini-code-assist

Code Review

This pull request refactors the math library by moving it from libphoenix to a standalone libm directory, introducing architecture-specific hardware-accelerated implementations alongside a software-based fallback. The review identified several critical issues, including a logic error in sinhf, a function name typo in truncf, a C99 linkage issue with inline functions, a syntax error in nanf, and potential build failures in the Makefile. Additionally, minor typos in the documentation were addressed.

github-actions · 2026-07-21T11:22:01Z

Unit Test Results

13 730 tests ±0 12 871 ✅ ±0 57m 13s ⏱️ +41s
780 suites ±0 859 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 7df046f. ± Comparison against base commit 9bffcee.

♻️ This comment has been updated with latest results.

oI0ck

Please apply the suggested codespell changes

Darchiv

Minor nitpicks. Also please address all typos (those revealed by gemini, in commit messages, etc.), change PR's name to something meaningful, and rerun CI.

Please make it clear in PR's description that you import an external math library (libmcs) as a submodule. ("Adding a new math library implementation" looks a bit too vague and may be misinterpreted.)

Darchiv

Not all nitpicks were addressed (typos) but LGTM nonetheless.

Please rerun CI by rebase + force push in order to run cpptest (recently enabled by default on stm32n6)

kber-ps

LMGT

ziemleszcz · 2026-08-25T08:09:06Z

complex.h header is broken when using libphoenix implementation (default settings from libm/Makefile):

/src/_build/ia32-generic-qemu/sysroot/usr/include/complex.h:21:6: error: #error During the configure step you have chosen not to compile complex procedures as such you should not include complex.h in your software.

ziemleszcz · 2026-08-25T07:48:36Z

+LIBM_USE_HW ?= y
+
+# Set options for denormals on the FPU
+ifeq ($(LIBM_LIBMCS_DAZ), y)


README.md says it's applicable only for libmcs. Guard it by LIBM_USE_LIBMCS?

Suggestion was applied.

Is it LIBM_LIBMCS_DAZ or LIBMCS_FPU_DAZ?

@ayoopierre provide Your response here so we can sloe this

The LIBM_LIBMCS_DAZ is a build system level flag, while internally macro used in libmcs code is LIBMCS_FPU_DAZ. Wanted to keep all math library configuration flags with LIBM prefix.

LIBM_LIBMCS_DAZ seems to be dead variable.

I guess it is not required to be here. It is used in in top makefile for feature config. I can delete it but it provides default configuration in one place and clearly shows what configuration is possible.

YT: RTOS-1132

ayoopierre requested a review from a team July 21, 2026 09:58

github-actions Bot reviewed Jul 21, 2026

View reviewed changes

gemini-code-assist Bot reviewed Jul 21, 2026

View reviewed changes

Comment thread libm/phoenix/mathf/sinhf.c

Comment thread libm/arch/aarch64/truncf.c

Comment thread libm/arch/ia32/sqrtd.c Outdated

Comment thread libm/phoenix/compatibility.c

Comment thread Makefile Outdated

Comment thread libm/README.md Outdated

Comment thread libm/README.md Outdated

ayoopierre force-pushed the ayopierre/libm branch from aeed5b9 to c948336 Compare July 21, 2026 14:35

ayoopierre requested a review from Darchiv July 21, 2026 15:03

kber-ps reviewed Jul 23, 2026

View reviewed changes

Comment thread libm/arch/aarch64/ceild.c Outdated

kber-ps requested changes Jul 23, 2026

View reviewed changes

oI0ck previously requested changes Jul 23, 2026

View reviewed changes

ayoopierre force-pushed the ayopierre/libm branch 3 times, most recently from 10d5b21 to 55e5cb1 Compare July 24, 2026 13:37

github-actions Bot reviewed Jul 24, 2026

View reviewed changes

Comment thread libm/arch/armv8m/sqrtd.c Outdated

ayoopierre force-pushed the ayopierre/libm branch from 55e5cb1 to 167cc91 Compare July 29, 2026 12:17

ayoopierre requested a review from oI0ck July 31, 2026 15:42

Darchiv previously approved these changes Aug 7, 2026

View reviewed changes

Comment thread libm/Makefile Outdated

Comment thread libm/README.md Outdated

Darchiv requested a review from kber-ps August 7, 2026 17:21

ayoopierre dismissed Darchiv’s stale review via 33d8f4b August 10, 2026 15:36

ayoopierre force-pushed the ayopierre/libm branch from 167cc91 to 33d8f4b Compare August 10, 2026 15:36

ayoopierre changed the title ~~Ayopierre/libm~~ libm: Import secondary math library implementiaion Aug 11, 2026

Darchiv previously approved these changes Aug 18, 2026

View reviewed changes

ayoopierre force-pushed the ayopierre/libm branch from 33d8f4b to 8647e8f Compare August 18, 2026 15:54

ayoopierre mentioned this pull request Aug 19, 2026

Temporary commit phoenix-rtos/phoenix-rtos-project#1741

Closed

3 of 14 tasks

kber-ps previously approved these changes Aug 24, 2026

View reviewed changes

ziemleszcz reviewed Aug 25, 2026

View reviewed changes

ayoopierre dismissed stale reviews from kber-ps and Darchiv via 455ff6d August 26, 2026 15:32

ayoopierre force-pushed the ayopierre/libm branch from 455ff6d to 698f617 Compare August 26, 2026 15:40

libm: Fix complex.h configuration

3eae29a

YT: RTOS-1132

ayoopierre force-pushed the ayopierre/libm branch 3 times, most recently from 59e720b to f13ac41 Compare September 25, 2026 11:43

phoenix-rtos deleted a comment from github-actions Bot Sep 25, 2026

adamgreloch reviewed Sep 25, 2026

View reviewed changes

Comment thread libm/include/complex.h Outdated

Mikołaj Matałowski added 2 commits September 25, 2026 15:43

libm: Move includes to libphoenix

ee7b7a0

YT: RTOS-1132

libm: Fix math errno/math err except

7df046f

YT: RTOS-1132

Conversation

ayoopierre commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation and Context

Types of changes

How Has This Been Tested?

Checklist:

Special treatment

Uh oh!

github-actions Bot Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Results

Uh oh!

Uh oh!

oI0ck left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Darchiv left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Darchiv left a comment

Choose a reason for hiding this comment

Uh oh!

kber-ps left a comment

Choose a reason for hiding this comment

Uh oh!

ziemleszcz commented Aug 25, 2026

Uh oh!

ziemleszcz Aug 25, 2026

Choose a reason for hiding this comment

Uh oh!

ayoopierre Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ziemleszcz Aug 27, 2026

Choose a reason for hiding this comment

Uh oh!

kber-ps Oct 1, 2026

Choose a reason for hiding this comment

Uh oh!

ayoopierre Oct 2, 2026

Choose a reason for hiding this comment

Uh oh!

ziemleszcz Oct 2, 2026

Choose a reason for hiding this comment

Uh oh!

ayoopierre Oct 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

ayoopierre commented Jul 21, 2026 •

edited

Loading

github-actions Bot commented Jul 21, 2026 •

edited

Loading

Darchiv left a comment •

edited

Loading

ayoopierre Aug 26, 2026 •

edited

Loading