unistd: handle required _SC* values in sysconf - #520
adamgreloch wants to merge 6 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request expands the sysconf implementation by defining and adding support for numerous POSIX system configuration constants (_SC_*). It also updates _SC_OPEN_MAX to return -1 for POSIX compliance. The review feedback highlights several areas for improvement: ensuring that limits associated with unsupported options also return -1 to comply with POSIX standards, returning defined limits like NGROUPS_MAX and PTHREAD_DESTRUCTOR_ITERATIONS instead of their POSIX minimums, and adding the missing _SC_CLK_TCK case to the sysconf switch statement.
6a9bd18 to
24ae168
Compare
Unit Test Results (nightly) 1 files 3 206 suites 6h 14m 7s ⏱️ For more details on these failures, see this check. Results for commit 2ec657f. ♻️ This comment has been updated with latest results. |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request expands POSIX compliance by defining numerous _SC_* configuration constants in include/unistd.h and implementing their handling in sysconf within unistd/conf.c. Additionally, _SC_OPEN_MAX now returns -1 to remain POSIX-compliant. The review feedback suggests improving sysconf by returning the defined PTHREAD_DESTRUCTOR_ITERATIONS and NGROUPS_MAX constants instead of returning -1 or fallback values, respectively.
24ae168 to
b674acc
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request expands POSIX compliance by defining numerous SC* configuration macros in include/unistd.h and implementing them in sysconf inside unistd/conf.c. It also updates _SC_OPEN_MAX to return -1 to remain POSIX-compliant. Feedback suggests simplifying the large block of contiguous switch cases for unsupported options in sysconf by using a range check in the default block to improve readability.
b674acc to
132609e
Compare
TASK: RTOS-1438
TASK: RTOS-1438
TASK: RTOS-1438
Assisted-by: claude-opus-5 TASK: RTOS-1438
Fixes: phoenix-rtos/phoenix-rtos-project#1458 Assisted-by: claude-opus-5 TASK: RTOS-1438
132609e to
2ec657f
Compare
|
Reworked the PR a bit. Running nightly once more to make sure the changed definitions don't break lsb_vsx. |
2 participants
TASK: RTOS-1438
Fixes: phoenix-rtos/phoenix-rtos-project#1458
Description
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment