Allow FormTypeExtensionInterface to be visited like FormTypeInterface - #192
Merged
Conversation
…he same way that classesd implementing FormTypeInterface
Contributor
Author
|
Not sure I undestand the failure. Somehow on php8.2 two usecases are not failing 🤔 |
Contributor
Author
|
This should be reworked if #194 is merged by using FQN since symfony/form is dev-required |
Member
Contributor
Author
|
This one looks fine now 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #191
Allow classes implementing FormTypeExtensionInterface to be visited the same way that classesd implementing FormTypeInterface.
I've added a very basic tests and an early break in the loop.
When the lib is php >= 8.4 we can use array_find instead