Repository navigation
Conversation
This was referenced Oct 14, 2026
Member
Author
|
@devnexen can you check this no longer crashes the test case you had? |
Member
|
no crash :) |
Girgias
force-pushed
the
2026-10-class_lookup2
branch
from
October 15, 2026 11:14
7b8d42e to
d1e51db
Compare
Girgias
marked this pull request as ready for review
October 16, 2026 11:02
ndossche
reviewed
Oct 19, 2026
ndossche
left a comment
ndossche
left a comment
Member
There was a problem hiding this comment.
I agre with the idea, see my nit
| zend_string_release_ex(lc_name, 0); | ||
| return NULL; | ||
| } | ||
| ZEND_ASSERT(zend_is_valid_class_name(name) && "If lowercase name is valid the name must also be so"); |
Member
There was a problem hiding this comment.
I'm not sure if the compiler is smart enough to avoid this call in release builds
Member
Author
There was a problem hiding this comment.
Sorry this took a while and it's now done.
Member
There was a problem hiding this comment.
with debug build I get the assertion fired with just this (there are probably other cases)
''::foo();
Member
There was a problem hiding this comment.
Interesting, nice find, that should be fixed first.
Possible now that zend_is_valid_class_name() correctly rejects empty strings.
Girgias
force-pushed
the
2026-10-class_lookup2
branch
from
October 31, 2026 06:40
d1e51db to
43316ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commits should be reviewed individually
Supersedes #24277 and #24271