Repository navigation
Conversation
Contributor
|
TBH, I'm not fan of claude proxing PRs like this one without even understanding the matter. We all have access to AI and such PRs only prolong the fix, by ping-poing what's missing/incomplete/incorrect. You use AI even for all your comments in other PRs, that's not very efficient, and in some perception simply rude. Please, stop sending PRs, at least for Why do you think CVE fix that was coordinated by multiple PHP core maintainers and biggest cybersecurity companies should be improved by your suggestion? Do you even have access to frontier AI models that could verify this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the upload progress handler started decoding the session with every object kept as
__PHP_Incomplete_Class, it refuses records that have a property named__PHP_Incomplete_Class_Name,__PHP_Incomplete_Class_Serializedor__PHP_Incomplete_Enum_Case. That refusal went through the normal decode failure path, which destroys the session, even though a regularsession_start()reads the same record without a problem.When the decode fails inside the upload progress handler, the session is now only closed and the progress update is skipped, so the stored record stays as it was and the request deals with it when it starts the session itself. I updated the expectations of
rfc1867_incomplete_class_reserved_props.phptto match.Fixes GH-24493