Repository navigation
Conversation
ndossche
approved these changes
Oct 31, 2026
SyntX34
pushed a commit
to SyntX34/php-src
that referenced
this pull request
Nov 1, 2026
* PHP-8.4: Fix phpGH-25089: Heap buffer over-read via crafted alias size in zip-based phar (php#25099)
SyntX34
pushed a commit
to SyntX34/php-src
that referenced
this pull request
Nov 1, 2026
* PHP-8.5: Fix phpGH-25089: Heap buffer over-read via crafted alias size in zip-based phar (php#25099)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
phar_parse_zipfile()set the alias length from the size claimed in the zip headers before reading the alias, but the buffer only holds what was actually decompressed. A smaller payload madephar_validate_alias()andPhar::getAlias()read past the buffer, so the length is now taken after the read.Fixes #25089