Skip to content

Fix GH-25094: NULL dereference in SOAP get_doc_function() with missing parts - #25101

Open
lazerg wants to merge 2 commits into
php:PHP-8.4from
lazerg:fix/gh-25094-soap-doc-function
Open

lazerg wants to merge 2 commits into
php:PHP-8.4from
lazerg:fix/gh-25094-soap-doc-function

Conversation

@lazerg

@lazerg lazerg commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

In document style, get_doc_function() walks the request Body elements alongside the WSDL parts, but it never checks whether it ran out of elements. When the Body has fewer elements than the operation declares, node becomes NULL and the next part comparison dereferences it. Now it treats that as no match, so the request gets the same "Procedure not present" fault as any other mismatch.

Fixes #25094

--EXTENSIONS--
soap
--INI--
soap.wsdl_cache_enabled=0

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

credits...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added cxxz16 under --CREDITS-- in 9e213bd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants