Repository navigation
Fix UAF in reflected attribute write paths - #25120
Merged
Merged
Conversation
Reflected className/id writes and TokenList mutations call xmlSetNsProp(), which frees an existing attribute child list. Unlink live child wrappers before replacement, following phpGH-23348.
bukka
force-pushed
the
dom_reflected_attribute_uaf
branch
from
November 1, 2026 10:49
78d9acc to
8f7f8d2
Compare
devnexen
reviewed
Nov 1, 2026
devnexen
approved these changes
Nov 1, 2026
bukka
added a commit
that referenced
this pull request
Nov 1, 2026
* PHP-8.4: Fix UAF in reflected attribute write paths (#25120)
bukka
added a commit
that referenced
this pull request
Nov 1, 2026
* PHP-8.5: Fix UAF in reflected attribute write paths (#25120)
bukka
added a commit
that referenced
this pull request
Nov 1, 2026
* PHP-8.6: Fix UAF in reflected attribute write paths (#25120)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reflected className/id writes and TokenList mutations call xmlSetNsProp(), which frees an existing attribute child list. Unlink live child wrappers before replacement, following GH-23348.