Repository navigation
Fix calling conventions in Windows alertable sleep test - #25125
Merged
shivammathur merged 1 commit intoNov 1, 2026
Merged
Conversation
Place __stdcall outside the function-pointer parentheses, where FFI applies it to the function type. The nested placement is ignored and creates a cdecl APC callback, corrupting the Windows dispatcher stack on x86.
shivammathur
added a commit
that referenced
this pull request
Nov 1, 2026
* PHP-8.6: Fix calling conventions in Windows alertable sleep test (#25125)
kairosci
pushed a commit
to kairosci/php-src
that referenced
this pull request
Nov 1, 2026
* PHP-8.4: Fix calling conventions in Windows alertable sleep test (php#25125)
kairosci
pushed a commit
to kairosci/php-src
that referenced
this pull request
Nov 1, 2026
* PHP-8.5: Fix calling conventions in Windows alertable sleep test (php#25125)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to GH-24399.
x86 CI: https://github.com/shivammathur/php-src/actions/runs/41305220966/job/124844121220