Repository navigation
Conversation
iliaal
approved these changes
Nov 2, 2026
iliaal
left a comment
iliaal
left a comment
Member
There was a problem hiding this comment.
Looks good, thanks for the fix. Please squash the two commits into one: the first on its own releases constant types that trait and lazy-loaded copies still share with the source class, which ends in a use-after-free.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
destroy_zend_class() never released the type of user class constants. Without opcache the class names in those types are interned, so nothing showed up, but with opcache they stay refcounted until persistence, and any class that isn't cached (eval'd code, the parser fuzzer) leaks them. The type is now released for constants the class owns, same as property types. Inherited CONST_OWNED copies are skipped since they share the parent's type.
Trait constants and constants of lazy loaded classes are copied with ce set to the new class, so their type is now deep copied the same way property types are. Otherwise the new release would free a type the class doesn't own.
Fixes #25149