Repository navigation
Fix GH-25148: Blocking socket fread() reports timed_out on Windows after returning buffered data - #25152
Open
jack-worman wants to merge 1 commit into
Open
Fix GH-25148: Blocking socket fread() reports timed_out on Windows after returning buffered data#25152jack-worman wants to merge 1 commit into
jack-worman wants to merge 1 commit into
Conversation
… after returning buffered data Since the fix for bug #51056, a blocking read that already has data buffered only checks for more without waiting. Windows has no MSG_DONTWAIT, so it checks with a zero-timeout poll, and when that poll found nothing, timeout_event was set and stream_get_meta_data() reported timed_out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25148.