Repository navigation
ext/date: Fix strtotime() handling of embedded NUL bytes - #25153
Open
arshidkv12 wants to merge 2 commits into
Open
arshidkv12 wants to merge 2 commits into
arshidkv12 wants to merge 2 commits into
Conversation
iliaal
reviewed
Nov 2, 2026
iliaal
left a comment
Member
There was a problem hiding this comment.
This isn't specific to strtotime(). timelib's scanner skips \0 like a newline, so new DateTime("\0"), modify() and date_parse() accept it as "now" too, and "2026-11-02\0 +1 year" parses fully. A check here only makes strtotime() disagree with the rest of ext/date. The fix belongs in timelib (derickr/timelib, v2022 branch): either treat NUL like whitespace in the empty-string trim in timelib_strtotime(), or report it as an unexpected character so every entry point fails the same way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #25150
Current output:
Expected output:
strtotime()should returnfalsewhen the input contains a NUL byte.