Define coordinated cleanup failure cause retention - #35
Merged
Merged
Conversation
alexstandiford
changed the base branch from
codex/coordinated-database-contracts-v2
to
codex/uncached-primary-schema-v2
September 18, 2026 19:03
alexstandiford
changed the base branch from
codex/uncached-primary-schema-v2
to
release/2.2
September 20, 2026 12:15
alexstandiford
marked this pull request as ready for review
September 20, 2026 12:16
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Keep both failures when a coordinated operation fails and its cleanup also fails. Implemented at eef38f3, stacked on Uncached primary and junction schema lookup, PR 34. This exception enables no database coordination by itself.
PHPNomad architecture: Coordinated cleanup failure (Source 9816) defines the contract within Discovery: Siren CRM core (Source 9721).
Contract
CoordinatedOperationCleanupFailedException extends the existing unknown-outcome exception. Its previous cause is the exact cleanup failure. getOperationFailure returns the exact earlier failure. The constructor accepts Exception or Error for each cause.
Existing unknown-outcome and datastore-failure catches remain compatible. This does not grant retry eligibility or add obligations to existing implementations. The outer message is fixed and contains no private cause details. The class has no connection, driver, logging, or datastore-instance dependency.
Verification
The combined production suite passes 147 tests and 421 assertions, without skipped or incomplete cases. The focused exception contract passes four tests and 52 assertions. Focused class-and-test level-nine analysis, syntax, and diff checks pass.
The architecture record retains the original disposable proof. PHPNomad proof: Cleanup exception guard supplement (Source 9838) supplies independent evidence for datastore catch compatibility, non-conflict classification, and cleanup-side instance independence. All contract guards have conforming and deliberate-defect evidence, with clean restoration.
All 14 architecture lenses and all 14 final independent production-review lenses pass. Every finding is closed. The implementation and proof retrospective is in Schema helpers are implemented, and query binding exposed a global connection path (Journal 18598).
Full package level-nine analysis retains 231 inherited findings. Formatting and unchanged README spelling baselines remain open, with no suppression. CI uses PHP 8.2 and Composer-locked PHPUnit 9.6.22. Current-head GitHub test jobs pass.
Remaining proof
The PDO adapter must prove both retained causes and one privacy-safe log when rollback fails after callback, coordination, or commit failure, including logger failure. The WordPress adapter and application path need their own proofs.
Full CI, application validation, UAT, and dependency publication remain open. This draft has no composite score or merge eligibility. No pull request has been merged, released, or deployed.