test(billing): guard ledger paging by design, not wall-clock time

[PierreBrisorgueil]

The ledger page test asserted a fixed < 50ms and flaked on busy CI runners. Timing could not catch the real regression anyway: at 1000 entries, reading the whole document costs about the same as the paged query. The test now asserts the design: page 1 comes from one aggregation that slices server-side, never from findOne/find, and returns the right page. Checked by swapping the repository to a full-document read: the test fails. No timing, so no flake. Test only.

Closes #3950 · epic #4019

https://claude.ai/code/session_015td7sshifbRrYrHbKgheiR

[coderabbitai]

Warning

Review limit reached

Next included review available in 15 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: pierreb-devkit/Node/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 316c1e5d-c9d6-48a9-afa1-24324678d51e

📥 Commits

Reviewing files that changed from the base of the PR and between 7842528 and ef1c26b.

📒 Files selected for processing (1)

• modules/billing/tests/billing.extraBalance.listLedger.perf.integration.tests.js

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.48%. Comparing base (7842528) to head (ef1c26b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4143   +/-   ##
=======================================
  Coverage   94.48%   94.48%           
=======================================
  Files         170      170           
  Lines        6036     6036           
  Branches     1946     1947    +1     
=======================================
  Hits         5703     5703           
  Misses        271      271           
  Partials       62       62           

Flag	Coverage Δ
integration	64.26% <ø> (ø)
unit	79.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7842528...ef1c26b. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.