Skip to content

[Grid Sidebar] Fix title/icon alignment and spacing consistency - #4252

Merged
idaiv merged 1 commit into
2026.xfrom
grid-sidebar-styling-2599
Oct 22, 2026
Merged

idaiv merged 1 commit into
2026.xfrom
grid-sidebar-styling-2599

Conversation

@idaiv

@idaiv idaiv commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Summary

Addresses the styling inconsistencies raised in #2599 across the grid listing sidebar's four tabs (Search & Filter, Tag Filters, Grid Config, Selected Elements):

  • Align each tab's title with the first sidebar rail icon (vertically centered, pixel-verified), and add a bit more breathing room above the icon stack.
  • Make left/right content padding (12px) consistent across all four tabs, matching the grid-config panel.
  • Remove the icon from the "Clear all filters" buttons (general filters and tag filters), per the ticket's icon decluttering ask.
  • Fix vertical alignment and add a 4px lead-in for the "Only direct children" / "Only unreferenced" filter checkboxes.
  • Vertically center the Field Filters empty state within its available space instead of sitting flush under the title.
  • Slightly increase the Grid Config title-to-list gap.
  • Swap a few hardcoded pixel values for their equivalent design tokens (header height/gap, stack-list gap, sidebar nav padding) for consistency with the rest of the token-driven spacing system.

Closes #2599

Test plan

  • Lint clean on all changed files
  • Manually verified in a running Studio instance: all four sidebar tabs (Search & Filter, Tag Filters, Grid Config, Selected Elements) measured for padding consistency and title/icon alignment via devtools pixel measurements
  • Checkbox centering and Field Filters empty-state centering visually and numerically verified
  • Reviewer sign-off on visual result in a real browser

Addresses several styling inconsistencies from #2599 across the grid
listing sidebar (Search & Filter, Tag Filters, Grid Config, Selected
Elements tabs):

- Align each tab's title with the first sidebar rail icon, and give
  the rail a bit more breathing room above the icon stack.
- Make left/right content padding (12px) consistent across all four
  tabs, matching the grid-config panel.
- Remove the icon from the "Clear all filters" buttons.
- Fix vertical alignment and add proper lead-in spacing for the
  "Only direct children" / "Only unreferenced" filter checkboxes.
- Vertically center the Field Filters empty state within its
  available space instead of sitting flush under the title.
- Increase the Grid Config title-to-list gap slightly.
- Swap a few hardcoded pixel values for their equivalent design
  tokens (header height/gap, stack-list gap, sidebar nav padding).

Closes #2599

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 22, 2026 13:34
@sonarqubecloud

Copy link
Copy Markdown

@idaiv idaiv added this to the 2026.4.0 milestone Oct 22, 2026
@idaiv
idaiv merged commit 0036abe into 2026.x Oct 22, 2026
19 of 20 checks passed
@idaiv
idaiv deleted the grid-sidebar-styling-2599 branch October 22, 2026 13:41
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Grid Sidebar] Styling Improvements

1 participant