Repository navigation
Conversation
…oltip on data object field labels Hovering a data object field label in the edit view and in the grid edit modal shows the field's class-definition key, as in the legacy admin UI. The data object form item and the grid edit modal provide the plain definition name (the key name for classification store keys) to FieldLabel through a context; document editables render FieldLabel without it and stay unchanged. The help icon keeps its tooltip. Co-Authored-By: Claude <noreply@anthropic.com>
…nder an element Sonar's function-name rule reads mocked components that return null as plain functions. Co-Authored-By: Claude <noreply@anthropic.com>
…mins only Co-Authored-By: Claude <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Changes in this pull request
Resolves pimcore/platform-version#522
In the legacy admin UI, hovering a data object field's label showed the field's technical name, which is needed to write queries in the object grid's advanced search. Studio's field labels had no such tooltip.
Studio now shows it the way the legacy UI did (
admin-ui-classic-bundleobject/helpers/edit.js): for admins only, the plain field name as a tooltip on the label text.FieldLabelwraps the label text in Studio'sTooltipwhen a technical name is provided through the newFieldLabelTechnicalNameProvidercontext. Without the provider it renders exactly as before, so document editables and every other caller are unchanged.DataComponentFormItem) and by the grid's inline-edit modal (DataObjectAdapterCell). It passes the name only when the current user is an admin (useUser().isAdmin).For reviewers to weigh:
FieldLabeland the SDK-exportedDataObjectAdapterCellgain opt-in behaviour; no signatures change.Additional info
Tests
field-label.test.tsx: an admin sees the technical name on the label text; a non-admin does not; a document editable label gets no tooltip.form-item.test.tsx,data-component.test.tsx: the plain key for top-level fields, block items, localized fields and classification store keys.data-object-adapter-cell.test.tsx: the grid edit modal's label gets the column's plain key.Verified
check-types,lint,npm test(1932 tests) andbuild-apppass.isAdmin: false: no tooltip on the labels.Not verified
The build output is not part of this PR.
🤖 Generated with Claude Code