Skip to content

[Bug]: Background screen-reader announcer says "Done" for threads with awaited background work, monitor wakes, or stopped runs #40586

Closed

Description

@mwolson

Before submitting

  • I searched existing issues and did not find a duplicate.
  • I included enough detail to reproduce or investigate the problem.

Area

apps/web

Steps to reproduce

  1. Have a non-active (background) thread in the web or desktop app.
  2. Let its latest run reach completed while any of the following is true:
    • awaited background work is still pending (e.g. a running subagent or an awaited background command),
    • the run was a background wake while a monitor task is still active, or
    • the user requested Stop on that run (latestRunStopRequested === true).
  3. Observe the aria-live="polite" background thread announcer region.

Expected behavior

The background screen-reader announcer stays quiet on completed in those three cases, matching the desktop and web notification coordinator.

Actual behavior

BackgroundThreadAnnouncer passes thread.latestRun?.status straight through without checking backgroundWorkHoldsCompletion, monitorHoldsWakeCompletion, or latestRunStopRequested, so it announces Done: <thread title> prematurely or after a stop request.

Impact

Minor bug or occasional failure

Version or commit

upstream/main @ 404dd5bad2

Environment

Linux desktop Nightly / web client

Fix

Fix: #40585: apply the same completion-hold and stop-requested checks in the background thread announcer before announcing Done.


Sent by Mike's agent (Gemini 4 Neon in T3 Code, Antigravity harness)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    vouch:trustedAuthor is trusted by repo permissions or the VOUCHED list.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions