Repository navigation
feat(web): chats, files, terminals and PRs open as tabs in split panes - #28845
maria-rcks wants to merge 680 commits into
Conversation
|
Macroscope skipped reviewing this pull request. Per-review cost limit exceeded (workspace setting). This review would cost an estimated $97.72, which exceeds your per-review limit of $15.00. The top 3 files driving up this estimate:
Tip To get this pull request reviewed, you can:
|
ApprovabilityVerdict: Needs Human Approval Macroscope's review found this PR requires human approval — The change expands a lint configuration exception to allow Uniwind theme escape hatches in ComposerSurface.tsx. This diagnostic override requires human review under the repository’s stated requirements. Needs human approval because:
Review your spending limits in Billing settings, or comment |
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Other scenariosNo All 64 scenario measurements
Baseline: unavailable · PR result: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
f6f00d4 to
b653b87
Compare
b653b87 to
f0dd9b6
Compare
f0dd9b6 to
ba88740
Compare
ba88740 to
91b0851
Compare
91b0851 to
814c2e3
Compare
…pane and the sidebar The overview set two inherited variables on the app's root only while it showed, and made every pane and the sidebar inert: each change restyled everything under it, 14k to 23k elements in the opening frame at twelve columns. The variables are now always set, and the panes and the sidebar are aria-hidden instead; the overview already owns the keyboard, its layer and a cover over the sidebar take presses, and focus that lands under it is dropped.
…nd diffs again A file, diff or terminal tab unmounted when its workspace was left, so coming back parsed, highlighted and measured a whole file again: a 1.0 to 1.5 s task before the switch could move at twelve columns. Leaving also made those tabs inert while they still showed, which restyled everything they hold. The few most recent surfaces now stay rendered, hidden the way chats are. Hidden panes are aria-hidden instead of inert and keep their pointer-events (they sit out of the window), so neither hiding nor revealing restyles what they hold. Browser tabs still unmount.
|
@maria-rcks, images the agent opens no longer show anywhere in the chat on this stack. This looks like a regression of #30473. On Nightly, a Read of an image shows the image twice:
On the redesign build (a local build of layer 6 merged onto main, "T3 Code (Maria) 0.1.10"), neither appears. Expanding the Read row shows only the tool's raw result: Cause: a7b251e ("fix(web): keep image reads in the work log"), on layer 6, landed 14 hours after #30473 (5b11efe). It removes:
Layers 1 to 5 still have the row (4 If keeping image reads in the work log was intended for the redesign fold, the expanded Read row still needs the inline image. As it stands, the image can't be seen at all. 11ad711 ("lays out turns like main unless the redesign fold is on") suggests the fold-off layout was meant to match main, which shows the strip. Repro: ask any agent to read a PNG in the workspace, then compare the thread on Nightly and on this branch. Found by Claude Opus 5.5 (Claude Code) during a T3 Code triage session on behalf of Davies. |
… nothing it draws
…ng panels on every resize
… threads skip composer focus, as main's do
… layer 6's side chat pane did
…eline, panes and pickers
…and start from a fresh file in layer 6
…lit rim's inherited span
…ce and leaves the other tabs and panes alone Open in main view (the side chats list's menu and middle click, and now the side chat tab's own menu) turns the side chat's tab into its chat in the same pane and focuses it. It used to change the route in place, which replaced a ghost parent tab and hid the parent's other tabs and panes with it.
# Conflicts: # apps/server/src/orchestration-v2/Orchestrator.ts # apps/web/src/components/ChatMarkdown.browser.test.tsx # apps/web/src/components/ChatView.browser.test.tsx # apps/web/src/components/ChatView.tsx # apps/web/src/components/ComposerPromptEditorTiptap.tsx # apps/web/src/components/ReopenClosedViewShortcut.browser.test.tsx # apps/web/src/components/ReopenClosedViewShortcut.tsx # apps/web/src/components/ThreadStatusIndicators.tsx # apps/web/src/components/chat/ChatComposer.tsx # apps/web/src/components/chat/ComposerPrimaryActions.tsx # apps/web/src/components/chat/MarkdownFileLink.tsx # apps/web/src/components/chat/MessagesTimeline.browser.test.tsx # apps/web/src/components/chat/RightPanelSurfaceContent.tsx # apps/web/src/components/chat/SecretRequestCard.tsx # apps/web/src/components/chat/ThreadAutomationsPanel.tsx # apps/web/src/components/chat/useComposerSend.ts # apps/web/src/components/pullRequest/PullRequestRow.tsx # apps/web/src/components/pullRequest/pullRequestMarkdown.logic.ts # apps/web/src/components/settings/ScheduledTasksSettings.tsx # apps/web/src/components/settings/settingsSearch.ts # apps/web/src/components/ui/tooltip.browser.test.tsx # apps/web/src/components/ui/tooltip.tsx # apps/web/src/i18n/translations/de.json # apps/web/src/i18n/translations/en.json # apps/web/src/i18n/translations/es.json # apps/web/src/i18n/translations/fr.json # apps/web/src/i18n/translations/ja.json # apps/web/src/i18n/translations/ko.json # apps/web/src/i18n/translations/pt-BR.json # apps/web/src/i18n/translations/ru.json # apps/web/src/i18n/translations/sv.json # apps/web/src/i18n/translations/zh.json # apps/web/src/index.css # pnpm-lock.yaml
…er 6's default shortcuts
On layer 5 the chat owns the window. The terminal is a drawer under it, and diffs, files, the browser, pull requests and devices share one right panel.
Here each of those is a tab in a pane. Panes sit in columns, a column can split down, and every pane has its own tab strip. Drag a tab to reorder it. Cmd+\ opens a new pane, Cmd+T a new tab, Cmd+Shift+T restores a closed one. Pull requests, issues and both lists open as tabs. Cmd+N still asks which project when there are several, as on main, and the new thread replaces the focused tab. Settings › Layout sets the default panes and where the terminal and side pane open, once per device.
Settings › Labs › Scrolling workspaces is off by default. Off, a new pane shrinks the others to fit, and the workspace, overview and center-column commands do nothing and are hidden from keybindings, the palette and the shortcut sheet. On, panes keep their width and the strip scrolls sideways, extra workspaces stack with an overview (Cmd+Alt+O), and a layout intro, tour and hints appear.
layoutModel.tsholds workspaces, columns, panes and tabs.SurfaceHost.tsxrenders them and replacesChatRightPanel,RightPanelSheet,ChatTerminalDrawersandPersistentThreadTerminals.surfaceSync.tskeeps the right panel store and the tabs in step. The layer also adds a desktop app icon picker, Claude's context breakdown in thread details, and a Labs toggle that folds each turn's work.Read first:
apps/web/src/layout/layoutModel.ts: the workspace, column, pane, tab modelapps/web/src/layout/SurfaceHost.tsx: renders panes, strip and overviewapps/web/src/layout/surfaceSync.ts: thread surfaces mirrored into tabsapps/web/src/layout/PaneTabs.tsx: tab strip, drag, close, restoreapps/web/src/layout/useSyncLayoutBehavior.ts: what the Labs flag switchespackages/contracts/src/settings.ts: layout settings and defaultsNeeds approval: Theo for
apps/web/src/components/ui/scroll-area.tsx(neworientationprop; the scroll fade re-measures on resize), rootvite.config.ts(lint ceilings only: 50 lowered, 42 removed, none raised; no bundling),patches/@legendapp__list@3.7.3.patch(new: rows measured in layout pixels inside the scaled overview, plus animmediateWebShrinksoption),patches/@pierre%2Ftrees@1.0.0-beta.6.patch(new: the tree viewport leaves out overlaid chrome),pnpm-workspace.yaml(patchedDependencies entries for those two patches) andpnpm-lock.yaml(their patch hashes). Theo or Julius forpackages/contracts:settings.ts(LayoutSettingsand its template; client settingslayout,scrollingWorkspacesEnabledandlayoutThreeFingerSwipedefaulting to false,appIcon,turnWorkFoldEnabled; the panel animation default goes from 0 to 150 ms),keybindings.ts(tab.new,tab.next,tab.previous,tab.close, 25layout.*commands andpullRequests.toggle;rightPanel.newandrightPanel.toggleMaximizedretired but still decode),ipc.ts(shortcutandacceleratoron context menu items; optional desktop methods that forward layout chords from a focused preview),server.ts(the config'ssettingsalso decodes an older server'slayout, for migration only),orchestrationV2.ts(optionalretryOfRunIdon user messages and commands, optional token usagebreakdown),providerRuntime.ts(theContextBreakdownschema),server.test.ts,settings.test.ts.Stack
Do not merge: this stack still needs review. Each PR targets the one below it.
1-primitives-shell2-composer-timeline3-panels-pages4-settings-setup5-voice6-workspace-panes(this PR)What it looks like
Captured at 1440x900 from two isolated dev servers (layer 5 before, layer 6 after) with one copied database: made-up
harbor-labsrepos, freeReplay (dev)threads, and a local fake GitHub for #142 and #150. Sidebar ages differ because the sides ran minutes apart.The same chat, terminal and
store.ts: a drawer and a right panel become three panes, each with a tab strip.The same in light.
Pull request #142 opens as a tab next to the diff and the file.
Issue #150 leaves the full-page Issues view and opens as a tab beside the chat.
Thread details gains the checkout and changes rows; #142 stays linked with its checks.
New in this layer: three panes side by side, each with its own tabs.
Dragging store.ts to the front, Cmd+\ opening a new pane, then closing store.ts and restoring it with Cmd+Shift+T (9 seconds).
Settings gains a Layout page, and Labs gains Scrolling workspaces, off.
With it on: the overview shows four columns that no longer fit the window.
Checks
On Blacksmith at this head (311223e, main c5badf4 merged in): typecheck, lint (0 errors, 17 warnings), knip,
fmt --checkandi18n:checkpass. Web tests in four shards pass 3136, 1523, 1552 and 1288 after two test files were fixed and rerun. Server tests: 9208 pass, 15 skipped. After the last GitHub drift merge, 22 web files (373 tests), client-runtimecontextWindowand issues (32) and the desktop menu tests (7) pass.Not verified: dragging a tab onto another pane (it did not move in the capture run), reopening a closed issues tab with Cmd+Shift+T, desktop (three-finger swipe, forwarded chords from a preview, app icon), the mobile app, Safari, real providers (Claude context breakdown), the browser and device panes, the layout tour past its intro, extra workspaces, touch and narrow widths; mobile, desktop and shared suites not run.
Done with Claude Code (Opus 5.5) in T3 Code.