Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,6 @@ const detail: PullRequestDetailView = {
};

function setup({ paged }: { paged: boolean }) {
window.localStorage.removeItem("t3code.diffHideTestFiles");
__setClientSettingsForTests(DEFAULT_CLIENT_SETTINGS);
mocks.paged = paged;
mocks.shortPages = false;
Expand All @@ -201,19 +200,21 @@ function setup({ paged }: { paged: boolean }) {
mocks.diffCommits = [];
mocks.viewedPaths = null;
mocks.viewedListeners.clear();
localStorage.clear();
}

const tab = (
refreshToken: number,
revealRequest: { readonly path: string; readonly nonce: number } | null = null,
revealUrl?: string,
onRevealSettled?: (url: string) => void,
tabDetail: PullRequestDetailView = detail,
) => (
<PullRequestCodeTab
scrollerRef={() => {}}
environmentId={EnvironmentId.make("environment")}
reference={detail}
detail={detail}
reference={tabDetail}
detail={tabDetail}
selectedCommitOid={null}
onSelectedCommitChange={() => {}}
onRefresh={() => {}}
Expand Down Expand Up @@ -343,7 +344,6 @@ it("pages forward to a file asked for that is not loaded yet, then scrolls to it
__setClientSettingsForTests({ ...DEFAULT_CLIENT_SETTINGS, diffFilesCollapsed: true });
using _preferences = {
[Symbol.dispose]() {
window.localStorage.removeItem("t3code.diffHideTestFiles");
__setClientSettingsForTests(DEFAULT_CLIENT_SETTINGS);
},
};
Expand All @@ -366,6 +366,80 @@ it("pages forward to a file asked for that is not loaded yet, then scrolls to it
await expectFileHeaderShown(screen, container, "late.test.ts");
});

it("hides viewed files and shows them again", async () => {
setup({ paged: true });
mocks.viewedPaths = new Set(["early-0.ts"]);
await using screen = await render(tab(0), { container: pagedContainer() });
await expect.element(screen.getByText("early-0.ts", { exact: true }).first()).toBeVisible();
const hideViewed = screen.getByRole("button", { name: "Hide viewed files" });

await hideViewed.click();

await expect.element(screen.getByText("early-0.ts", { exact: true })).not.toBeInTheDocument();
await expect.element(screen.getByText("early-2.ts", { exact: true }).first()).toBeVisible();
await hideViewed.click();
await expect.element(screen.getByText("early-0.ts", { exact: true }).first()).toBeVisible();
});

it("keeps the Hide viewed files toggle while its saved filter is on and nothing is viewed", async () => {
setup({ paged: true });
mocks.viewedPaths = new Set();
localStorage.setItem("t3code.pullRequestHideViewedFiles", "true");
await using screen = await render(tab(0), { container: pagedContainer() });
await screen.getByRole("button", { name: "Hide viewed files" }).click();

await vi.waitFor(() =>
expect(localStorage.getItem("t3code.pullRequestHideViewedFiles")).toBe("false"),
);
});

it("marks a Shift-clicked range viewed after the first file of it was hidden", async () => {
setup({ paged: true });
mocks.viewedPaths = new Set(["early-0.ts"]);
const container = document.createElement("div");
container.className = "h-[500px] w-[400px]";
await using screen = await render(tab(0), { container });
await screen.getByRole("button", { name: "Hide viewed files" }).click();
await expect.element(screen.getByText("early-10.ts", { exact: true }).first()).toBeVisible();

await screen.getByRole("checkbox", { name: "Viewed" }).first().click();
await expect.element(screen.getByText("early-10.ts", { exact: true })).not.toBeInTheDocument();
await screen
.getByRole("checkbox", { name: "Viewed" })
.nth(1)
.click({ modifiers: ["Shift"] });

await expect.element(screen.getByText("early-11.ts", { exact: true })).not.toBeInTheDocument();
});

it("keeps conversations reachable when every file is hidden", async () => {
setup({ paged: false });
mocks.viewedPaths = new Set(["a.ts"]);
const threadDetail: PullRequestDetailView = {
...detail,
reviewThreads: [
{
id: "thread",
path: "a.ts",
line: 1,
side: "right",
isResolved: false,
isOutdated: false,
comments: [],
},
],
};
const container = document.createElement("div");
container.className = "h-[500px] w-[400px]";
await using screen = await render(tab(0, null, undefined, undefined, threadDetail), {
container,
});
await screen.getByRole("button", { name: "Hide viewed files" }).click();
await expect.element(screen.getByText("All files are hidden.")).toBeVisible();

await expect.element(screen.getByText("Conversations not on the current diff")).toBeVisible();
});

it("keeps a linked test file expanded when a refresh changes the rest of the diff", async () => {
setup({ paged: false });
mocks.withTestFile = true;
Expand Down
Loading
Loading