Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions apps/web/src/components/preview/PreviewChromeRow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -262,11 +262,15 @@ export function PreviewChromeRow({
<Button
variant={recording ? "secondary" : "ghost"}
size="icon-xs"
onClick={(event) => onCapture(event.shiftKey)}
onClick={(event) => {
if (!captureDisabled) onCapture(event.shiftKey);
}}
aria-label={recording ? gt("Stop recording") : gt("Capture screenshot")}
type="button"
className="relative"
disabled={captureDisabled}
// Stopping a recording on a failed page disables this button; a native disabled
// drops focus and workspace recovery moves it to the address bar.
aria-disabled={captureDisabled || undefined}
/>
}
>
Expand Down
78 changes: 60 additions & 18 deletions apps/web/src/components/preview/PreviewView.browser.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,16 @@ const mocks = vi.hoisted(() => ({
idleServerTab: false,
idleDesktopTab: false,
idleDesktopOverlay: false,
missingDesktopOverlay: false,
loading: false,
loadFailed: false,
nativeServerTab: false,
streamedServerTab: false,
serverEpoch: null as string | null,
servers: [] as PreviewableServer[],
recordingTabIds: new Set<string>(),
recordingRuntimeTabId: null as string | null,
stopBrowserRecording: vi.fn(async (_runtimeTabId: string) => null),
recordVisitForThread: vi.fn(),
}));

Expand All @@ -51,6 +54,13 @@ const STUB_BROWSER_DEFAULTS = {
profiles: BUILT_IN_BROWSER_PROFILES,
profileId: DEFAULT_BROWSER_PROFILE_ID,
};
const LOAD_FAILED = {
_tag: "LoadFailed",
url: "http://example.com/",
title: "",
code: -102,
description: "ERR_CONNECTION_REFUSED",
} as const;

// The desktop bridge only exists inside Electron; the view reads it once at import.
vi.mock(import("./previewBridge"), async (original) => ({
Expand Down Expand Up @@ -102,23 +112,27 @@ vi.mock(import("~/previewStateStore"), async (original) => ({
useThreadPreviewState: (() => ({
activeTabId: "tab-1",
serverEpoch: mocks.serverEpoch,
desktopByTabId: {
"tab-1": {
hasWebContents: true,
navStatus: mocks.idleDesktopOverlay
? { _tag: "Idle" }
: { _tag: "Success", url: "http://example.com/", title: "Example" },
canGoBack: false,
canGoForward: false,
loading: mocks.loading,
zoomFactor: 1,
pictureInPicture: mocks.pictureInPicture,
colorScheme: "system",
audioMuted: false,
audible: false,
controller: "none",
},
},
desktopByTabId: mocks.missingDesktopOverlay
? {}
: {
"tab-1": {
hasWebContents: true,
navStatus: mocks.loadFailed
? LOAD_FAILED
: mocks.idleDesktopOverlay
? { _tag: "Idle" }
: { _tag: "Success", url: "http://example.com/", title: "Example" },
canGoBack: false,
canGoForward: false,
loading: mocks.loading,
zoomFactor: 1,
pictureInPicture: mocks.pictureInPicture,
colorScheme: "system",
audioMuted: false,
audible: false,
controller: "none",
},
},
recentlySeenUrls: [],
sessions: mocks.showEmptyState
? {}
Expand All @@ -139,7 +153,9 @@ vi.mock(import("~/previewStateStore"), async (original) => ({
threadId: "thread-1",
tabId: "tab-1",
runtime: mocks.nativeServerTab || mocks.streamedServerTab ? "server" : "desktop",
navStatus: { _tag: "Success", url: "http://example.com/", title: "Example" },
navStatus: mocks.loadFailed
? LOAD_FAILED
: { _tag: "Success", url: "http://example.com/", title: "Example" },
canGoBack: false,
canGoForward: false,
updatedAt: "2026-07-13T00:00:00.000Z",
Expand All @@ -157,6 +173,7 @@ vi.mock(import("~/browser/browserRecording"), async (original) => ({
...(await original()),
findActiveBrowserRecordingRuntimeTabId: () => mocks.recordingRuntimeTabId,
useActiveBrowserRecordingTabIds: () => mocks.recordingTabIds,
stopBrowserRecording: mocks.stopBrowserRecording,
}));
vi.mock(import("./useDiscoveredLocalServers"), async (original) => ({
...(await original()),
Expand Down Expand Up @@ -235,7 +252,9 @@ function setup() {
mocks.idleServerTab = false;
mocks.idleDesktopTab = false;
mocks.idleDesktopOverlay = false;
mocks.missingDesktopOverlay = false;
mocks.loading = false;
mocks.loadFailed = false;
mocks.nativeServerTab = false;
mocks.streamedServerTab = false;
mocks.serverEpoch = null;
Expand Down Expand Up @@ -451,6 +470,29 @@ describe("PreviewView", () => {
expect(listeners.size).toBe(0);
});

it.each([
{ state: "the page fails to load", loadFailed: true, missingDesktopOverlay: false },
{ state: "the desktop page state is gone", loadFailed: false, missingDesktopOverlay: true },
])("stops an active recording after $state", async (state) => {
setup();
mocks.loadFailed = state.loadFailed;
mocks.missingDesktopOverlay = state.missingDesktopOverlay;
mocks.recordingTabIds = new Set([TEST_RUNTIME_TAB_ID]);
await using screen = await render(view());

const stop = page.getByRole("button", { name: "Stop recording" });
await expect.element(stop).toBeEnabled();
await userEvent.click(stop);

expect(mocks.stopBrowserRecording).toHaveBeenCalledWith(TEST_RUNTIME_TAB_ID);

mocks.recordingTabIds = new Set();
await screen.rerender(view());
const capture = page.getByRole("button", { name: "Capture screenshot" });
await expect.element(capture).toHaveAttribute("aria-disabled", "true");
expect(document.activeElement).toBe(capture.element());
});

it("focuses the address bar each time the focus-url shortcut fires", async () => {
setup();
await using _screen = await render(view());
Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/components/preview/PreviewView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -1008,7 +1008,7 @@ export function PreviewView({
onSubmit={(next) => void handleSubmitUrl(next)}
onOpenInBrowser={tabId ? handleOpenInBrowser : undefined}
onCapture={previewBridge && tabId && !isServerTab ? handleCapture : undefined}
captureDisabled={!desktopOverlay || isUnreachable}
captureDisabled={recordingRuntimeTabId === null && (!desktopOverlay || isUnreachable)}
recording={recordingRuntimeTabId !== null}
onPictureInPicture={
tabId && (isServerTab || previewBridge) ? handlePictureInPicture : undefined
Expand Down
Loading