Repository navigation
fix(desktop): capture covered preview surfaces without hanging #33719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andrew-metaplanet
wants to merge
3
commits into
pingdotgg:main
Choose a base branch
from
andrew-metaplanet:fix/desktop-preview-capture
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+172
−1
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep the host's screenshot turn until the native copy settles.
takeScreenshotreleases its turn when the caller's 5-second deadline rejects the capture. The nativecapturePage()copy can still be pending at that point, and the native call cannot be cancelled. A later clipped, WebP, orcaptureBeyondViewportscreenshot then starts a CDPPage.captureScreenshotwhile that copy is still active.pendingViewportCopiesserializes only native copies, so it does not cover this overlap.The host comment says a screenshot copy the server gave up on stays pending in Chromium, and that each guest should get one copy at a time. It also says that overlapping copies make the Chromium renderer-exit crash (crbug.com/567321049) far more likely. This change can therefore reintroduce that crash risk on Chromium below 157.
Release the turn only when the underlying native copy settles, not when the caller deadline expires. The caller can still receive the timeout error at 5 seconds. The host gate must keep the next CDP or native screenshot waiting until the pending native copy settles. This keeps the existing deadline behavior while preserving the one-copy-per-guest invariant.