Repository navigation
fix(server): Claude publishes each background roster change once #34952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Vantrongs
wants to merge
4
commits into
pingdotgg:main
Choose a base branch
from
Vantrongs:fix/claude-roster-once
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+141
−22
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d939148
fix(server): Claude publishes each background roster change once
Vantrongs abc4442
Merge origin/main into fix/claude-roster-once
juliusmarminge ac0e8c9
Merge remote-tracking branch 'origin/main' into fix/claude-roster-once
Vantrongs ebb0ba4
Merge remote-tracking branch 'origin/main' into fix/claude-roster-once
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Record the suppression entry only when the enqueue completes.
emitProviderEventwriteslastProviderThreadUpdateswhen the function is called, but the event is queued only when the returnedQueue.offereffect runs. An interruption that lands between those two steps leaves a cache entry for an event that was never queued. The next roster event that matches the cached state is then suppressed. The server does not receive the change, such as anawaitedmark, until a different roster state is emitted.Move the cache write into the same effect as the enqueue. Record the entry after
Queue.offercompletes, or make the write and the enqueue run as one uninterruptible step. The first option can publish a duplicate after an interruption, which is harmless. Keep the enqueue interruptible if the queue can block.