Repository navigation
fix(clients): a one-hour snooze no longer reads "2h left" - #36785
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Pick up the unrelated Astro check expectation fix while preserving the existing snooze label contribution unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Snooze countdown labels now use clock-minute rounding so a one-hour snooze does not appear as two hours. The change affects display text only, not snooze timing or wake behavior. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
…ltas (#453) * feat(native): port #444 Part B Sidebar, Thread & Transcript parity deltas Port all remaining Sidebar, Thread View, and Transcript parity deltas from upstream `4121b30..80cf4f7` and flip `TV-LINEAGE` and `TR-WORK` to `done` in `apps/native/parity/LEDGER.md`. Sidebar (`SB-ROW`, `SB-SECTIONS`, `SB-MENU`, `SB-UNDO`, `SB-SEARCH`, `SB-GROUPING`): - Regenerating title glimmer (`pingdotgg#29383`) - Settle-undo position restore via `plan_undo_for_thread` + `UnsettleRestore`/`ReorderActive` (`pingdotgg#33248`) - Clear opened failed badge in sidebar rows and collapsed folder dots (`pingdotgg#28616`) - Suppress `Done` badge for stopped/interrupted/cancelled runs (`pingdotgg#37475`) - 1h snooze clock-minute rounding (`pingdotgg#36785`) - Opening a delegated task selects its listed parent ancestor (`pingdotgg#37500`) - Side-chat children included in worktree deletion check (`pingdotgg#36800`) - Failed message search error state in sidebar search and command palette (`pingdotgg#38155`) - Jump-hint modifier recheck after hold delay (`pingdotgg#38545`) - Command palette `Failed` status pill prioritized over background `Waiting` (`pingdotgg#38968`) Thread & Transcript (`TV-HISTORY`, `TV-LINEAGE`, `TV-FOLLOW`, `TR-WORK`, `TR-MARKDOWN`, `TR-CITE`, `TR-MCPAPP`): - Subagent history model preservation via `merge_older_subagents` (`pingdotgg#38724`) and hide Resume when `supportsNativeResume` is false without an unsent continuation source (`pingdotgg#39229`) - Cancel active smooth scroll in `keep_end` so finished-while-away threads open at end (`pingdotgg#38963`) - MCP PR/CI work-log rows & summaries (`pingdotgg#26751`, `pingdotgg#26752`) and Windows `pwsh`/`powershell`/`cmd` launcher unwrapping (`pingdotgg#38946`) - Leading-space user markdown preservation (`pingdotgg#38079`), RTL `<details>` and template cards (`pingdotgg#36876`, `pingdotgg#36922`), `Cite` on `send_to_user` rows (`pingdotgg#36858`), home/host paths out of workspace folder (`pingdotgg#39146`), and code/list/email copy serialization fixes (`pingdotgg#36712`, `pingdotgg#36830`, `pingdotgg#36867`, `pingdotgg#36915`, `pingdotgg#37284`, `pingdotgg#39150`) - MCP app content-block filtering for stripped images (`pingdotgg#31338`), teardown generation race test (`pingdotgg#30387`), and pre-query/fragment download filename derivation (`pingdotgg#30712`) * fix(native): address PR #453 review findings Address all 3 review findings from `@d1-reviewer` (`pingdotgg#847`): 1. Remove unwired DOM-HTML Markdown re-serialization helpers (`wrap_inline_code`, `serialize_markdown_anchor`, `escape_markdown_prose`, `ListCopyItem`, `serialize_list_slice`) from `crates/core/src/markdown/clipboard.rs` and update `TR-MARKDOWN` in `apps/native/parity/LEDGER.md` accurately. 2. Add `restore_preserved_leading_whitespace` and wire `user_markdown_view` with a `Copy` (`Cmd+C`) action interceptor (`crates/app/src/transcript/markdown.rs`, `messages.rs`) so user-message Copy and Cite restore ASCII spaces/tabs while preserving literal user-typed NBSPs (`pingdotgg#38079`), verified by GPUI test `user_markdown_copy_restores_leading_spaces_and_preserves_literal_nbsp`. 3. Fetch omitted family side chats via `fetch_family_side_chats` alongside `ORCHESTRATION_GET_WORKTREE_THREAD_IDS` in `delete_thread_then` (`crates/app/src/sidebar/controller.rs`, `pingdotgg#36800`) before calling `has_other_worktree_occupants`, verified by GPUI test `worktree_cleanup_prompt_excludes_omitted_family_side_chats` (and fixed `late_teardown_does_not_close_replacement_host` under `--features snapshot` in `transcript/mcp_app.rs`).
No items needed a change. All 36 checks on PR #36785 pass at 158dab8. Macroscope approved it with no comments on lines. CodeRabbit's review says 'No actionable comments were generated' and rates the merge risk Minimal. The fix itself is unchanged: snoozeWakeLabel counts whole clock minutes (floor(wake/min) - floor(now/min), at least 1) before choosing minutes, hours or days. Retained seconds therefore no longer push a one-hour snooze up to '2h' when
nowis cut to the minute.Supersedes #29787. The change is @saphid's; their commits are kept.
Reproduction on main
Reproduced on main at cebdf39:
Evidence
Web, Chromium, 1280×800, light theme; fresh synthetic database per revision. Create a Replay showcase thread, let it finish, open Thread actions → Snooze → In 1 hour about 20 seconds into a minute. Capture immediately and after the next minute boundary.
Proven: scenarios:prove exited 0, failing on base and passing on head.
Scenario source
Base failed the expected next-minute '59m left' assertion; head passed and also satisfied the initial '1h left' assertion.
Not shown:
Tests
No new local runs this round; the code is unchanged. CI on 158dab8: all 36 checks passed. Earlier, on this head: vp test run packages/client-runtime/src/state/threadSnoozed.test.ts passed (36 tests), vp run check:changed passed, and the new test fails against main's code.
Not in this change
Who did the work
Run by the t3code factory in T3 Code.