Repository navigation
fix(server): worktree thread lookups match any spelling of the path #36802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
juliusmarminge
merged 7 commits into
main
from
factory/pr-29792-a1794669027-2-worktree-path-lookup
Nov 22, 2026
+70
−13
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a64eefd
fix(web): deleting a thread with side chats offers to delete its work…
saphid 686f678
fix(server): worktree thread lookups match any spelling of the path
saphid 6918807
fix(server): index the loose worktree path lookup
github-actions[bot] a545ab4
test(server): expect the worktree path key migration
github-actions[bot] e25cfcd
Merge origin/main into factory/pr-29792-a1794669027-2-worktree-path-l…
juliusmarminge c85be72
Merge origin/main into factory/pr-29792-a1794669027-2-worktree-path-l…
juliusmarminge 1dedcfe
fix(server): non-ASCII worktree paths keep the index lookup
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
apps/server/src/persistence/Migrations/106_WorktreePathKeyIndex.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| import * as Effect from "effect/Effect"; | ||
| import * as SqlClient from "effect/sql/SqlClient"; | ||
|
|
||
| export default Effect.gen(function* () { | ||
| const sql = yield* SqlClient.SqlClient; | ||
|
|
||
| // Keep this expression identical to ProjectionStore's loose worktree filter. | ||
| yield* sql` | ||
| CREATE INDEX IF NOT EXISTS orchestration_v2_projection_threads_worktree_path_key_idx | ||
| ON orchestration_v2_projection_threads( | ||
| CASE WHEN json_valid(payload_json) | ||
| THEN lower(rtrim(replace(trim(json_extract(payload_json, '$.worktreePath')), '\\', '/'), '/')) | ||
| END | ||
| ) | ||
| `; | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reject scan details without a suffix.
SQLite can report an unindexed full scan as exactly
SCAN t. The trailing space instartsWith("SCAN t ")excludes that form, so this assertion accepts the full scan it must reject. SQLite documents this suffix-free format. (www3.sqlite.org)Use
/^SCAN t(?:\s|$)/to reject both plain scans and index scans.SEARCH t ...plans will still pass.