Repository navigation
fix(desktop): page dialogs in Browser tabs stay in their tab #37034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BelKed
wants to merge
18
commits into
pingdotgg:main
Choose a base branch
from
BelKed:t3/preview-dialogs-stay-in-tab
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+547
−56
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
7c05044
refactor(web): share the browser dialog card
BelKed 5b2f2e7
fix(desktop): page dialogs in Browser tabs stay in their tab
BelKed aaffcbe
fix(web): answer page dialogs in the desktop Browser panel
BelKed 20ff8e7
fix(desktop): hold page dialogs from guest attach
BelKed 7d12d21
fix(web): browser dialog card sits above the page
BelKed 907c200
fix(desktop): navigation dismisses a pending page dialog
BelKed 957aa8f
fix(desktop): closed tab drops its pending dialog
BelKed 2e42cb5
fix(desktop): tab dialog follows the live hold
BelKed 486cd38
Merge remote-tracking branch 'origin/main' into t3/dialog-hold-early
BelKed 99ac996
fix(desktop): prompt keeps Electron's rejection
BelKed c6a047b
fix(web): browser dialog card matches the app alert dialog
BelKed 87b8d48
Merge remote-tracking branch 'origin/main' into t3/dialog-hold-early
BelKed 2922d46
Merge remote-tracking branch 'origin/main' into t3/preview-dialogs-st…
juliusmarminge 2a7c0f6
fix(desktop): page dialog answers apply only to the dialog they were for
juliusmarminge 2e4d005
fix(web): page dialogs can be answered in the floating mini player
juliusmarminge 53dac3a
Merge remote-tracking branch 'origin/main' into t3/preview-dialogs-st…
juliusmarminge b62dd49
Merge remote-tracking branch 'upstream/main' into t3/preview-dialogs-…
BelKed 68200b1
fix(web): long page dialogs keep their buttons in view
BelKed File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.