Repository navigation
fix(server): a queued message's start no longer undoes a newer model pick #37518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
juliusmarminge
wants to merge
9
commits into
main
Choose a base branch
from
factory/issue-30547
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+328
−176
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
5f48bea
test(server): a queued message's start keeps a model picked after it …
juliusmarminge c34be8a
fix(server): a queued message's start no longer undoes a newer model …
juliusmarminge afc60d3
fix(server): a pinned scheduled delivery still moves the thread to it…
juliusmarminge cde22a4
fix(server): a message queued after a pick takes the pick, not an old…
juliusmarminge 91bf9c9
Merge remote-tracking branch 'origin/main' into factory/issue-30547
juliusmarminge 02dd637
fix(server): only a pinned scheduled delivery moves the thread back t…
juliusmarminge af34827
Merge remote-tracking branch 'origin/main' into factory/issue-30547
juliusmarminge 5b29f75
perf(server): a model pick reads only the thread's queued runs
juliusmarminge 5c83435
fix(server): a queued start after a superseded one resumes the active…
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟠 High
orchestration-v2/Orchestrator.ts:1033A superseded pinned scheduled run is omitted from the queue-tail selection, so a later model-less message is predicted to use
Beven thoughstartNextQueuedRunlets that scheduled run writeAback to the thread. The later message therefore runs onBinstead of inheriting the actual queue-tail selection; preserve the pinned-scheduled-run exception here.🚀 Reply "fix it for me" or copy this AI Prompt for your agent: