Repository navigation
fix(peer): Headscale tailnets can link environments over their 100.64.x addresses #37629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tecbeast42
wants to merge
5
commits into
pingdotgg:main
Choose a base branch
from
tecbeast42:fix/tailnet-ipv4-peer-links
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+213
−51
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
35952d3
fix(peer): Headscale tailnets can link environments over their 100.64…
tecbeast42 0cba879
test(peer): fold the tailnet IPv4 check into the existing interface case
juliusmarminge 93ad743
fix(peer): plain http to a 100.64.x address requires Tailscale to lis…
juliusmarminge 8fcf8df
fix(peer): a link resolve refuses is no longer listed as reachable
tecbeast42 31538f0
fix(peer): the Tailscale lookup no longer spends a listed link's prob…
tecbeast42 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not wait for every validation before starting probes.
If a link has a responsive HTTPS address and a shared-address HTTP alternative, this
forEachdelays the HTTPS probe until the Tailscale lookup finishes. A two-second lookup adds two seconds even when HTTPS answers immediately.forEachcompletes the collection before execution reaches the race. (raw.githubusercontent.com)Race independently validated contenders instead. Apply
LIST_PROBE_TIMEOUTonly to each contender's probe, after its validation. This preserves the lookup's separate budget without delaying unrelated addresses. Add a Deferred-based mixed-address regression case.