Repository navigation
fix(server): a Claude request that gets no answer fails after 10 minutes instead of running forever #37728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+212
−30
Merged
fix(server): a Claude request that gets no answer fails after 10 minutes instead of running forever #37728
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
401f13f
test(server): a Claude turn that goes silent after its prompt starts …
juliusmarminge e169588
fix(server): a Claude request that gets no answer fails after 10 minu…
juliusmarminge cafe8ea
fix(server): a Claude prompt that starts and then goes silent fails a…
juliusmarminge f083f14
fix(server): earlier background tasks no longer keep a silent Claude …
juliusmarminge 9ad11b7
fix(server): a long forked skill is not failed as a silent Claude req…
juliusmarminge 6eea821
fix(server): a nested task an earlier background agent starts does no…
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait for watchdog completion instead of scheduler ticks.
yieldTicks(50)runs a fixedEffect.yieldNowloop. It does not establish that watchdog cleanup and event collection have completed. After advancingTestClock, await aDeferredor event milestone that signals the expected terminal event.As per path instructions, tests must “drain the effect worker or await a specific persisted event or Deferred” and must not use polling.
Source: Path instructions