Repository navigation
fix(server): a thread_send follow-up waits only on background work its own runs started #37793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+395
−13
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
c9961fe
test(server): a follow-up held by the child's earlier background work…
juliusmarminge 5e8eb76
fix(server): a thread_send follow-up waits only on background work it…
juliusmarminge 2b5223d
fix(server): settle a follow-up when its own awaited work leaves the …
juliusmarminge 57e5be2
test(server): accept the run stamp on Claude monitor roster entries
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Synchronize the negative assertion on the tested child's own reactions.
The barrier waits on
barrier.childThreadId, a different thread from the one that carries the roster update for["a","b"]. Run reactions are keyed by thread, and the run-update and roster streams run in separate fibers. Barrier settlement does not show that the roster reaction has run. The assertion that A remainsrunningcan therefore pass before that reaction, so a regression that settles A on that update may go undetected.The comment that B's start "was handled" is also incorrect. The run-update filter drops
runningupdates, so B's update has no reaction to wait for. Remove that premise from the comment.Replace the barrier with a persisted milestone that the tested child's own reaction produces before the assertion. Choose that milestone carefully. The roster update that keeps A running produces no persisted event, so it cannot serve as the milestone.