Repository navigation
fix(opencode): restarted server stops shell commands that outlive an exited OpenCode server #37850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
StiensWout
wants to merge
6
commits into
pingdotgg:main
from
StiensWout:t3/1047-opencode-shell-commands-survive-restart
+123
−14
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4570385
test(opencode): restarted server stops shell children of an exited Op…
StiensWout 1f3a8af
fix(opencode): restarted server stops shell commands that outlive an …
StiensWout b33092a
fix(opencode): verify ownership of surviving shell groups
StiensWout 0488192
docs(opencode): clarify marker ownership proof
StiensWout 6c86089
Merge remote-tracking branch 'origin/main' into t3/1047-opencode-shel…
juliusmarminge e706ef6
refactor(opencode): drop the redundant boot-time guard from orphan cl…
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run the marker read under the same locale as the group scan.
readMarkerspawnsps ewwwithout anenvoption, so it inherits the parent locale.psDarwinsetsLC_ALL=C. With a UTF-8 locale and a non-ASCII executable path, the twopscalls can rendermember.commanddifferently. The prefix check at line 205 then fails,trackstores no marker, andleaderlessGroupRemainscannot match the surviving member. The ledger entry is still removed, so the surviving descendants keep running. Set the same locale on this call, withextendEnvso the rest of the environment is kept.Suggested fix
Committable suggestion